[Laszlo-dev] For Review: Change 20090526-maxcarlson-v Summary: Prevent stuck keys in OS X DHTML

Max Carlson max at openlaszlo.org
Tue May 26 14:45:09 PDT 2009


Change 20090526-maxcarlson-v by maxcarlson at Bank on 2009-05-26 14:35:12  
PDT
     in /Users/maxcarlson/openlaszlo/trunk-clean
     for http://svn.openlaszlo.org/openlaszlo/trunk

Summary: Prevent stuck keys in OS X DHTML

Bugs Fixed: LPP-8210 - phantom keys marked as down in DHTML  
lz.Keys.downKeysArray if you use the Apple key in OSX

Technical Reviewer: hminsky
QA Reviewer: ptw

Details: LzKeyboardKernel - Track meta (apple) key in __downKeysHash.   
Add __keyCodes hash to store original key codes for use later - so  
they can be retrieved based on the string value.  Prevent sending 224  
- meta key events.  If detectstuckkeys quirk is on (currently only OS  
X) detect keys that may still be down when the meta key goes up.  If a  
stuck key was found, generate an appropriate keyup event.

LzSprite - Add detectstuckkeys quirk, enable for OS X.

Tests: lz.Keys.downKeysArray no longer has extra entries for meta  
keys, e.g. 'a' after pressing/releasing apple-a.

Files:
M      WEB-INF/lps/lfc/kernel/dhtml/LzKeyboardKernel.js
M      WEB-INF/lps/lfc/kernel/dhtml/LzSprite.js

Changeset: http://svn.openlaszlo.org/openlaszlo/patches/20090526-maxcarlson-v.tar


More information about the Laszlo-dev mailing list