[Laszlo-dev] For Review: Change 20090522-maxcarlson-9 Summary: Fix IE memory leaks in drawview

[P T Withington]

I'm curious why drawview has to add its sprite to the __sprite's list,  
since the constructor for LzSprite already does this?  Basically I am  
concerned there is a pattern here that can be missed again and create  
another leak.

On 2009-05-22, at 19:22EDT, Max Carlson wrote:

> Change 20090522-maxcarlson-9 by maxcarlson at Bank on 2009-05-22  
> 16:17:48 PDT
>    in /Users/maxcarlson/openlaszlo/trunk-clean
>    for http://svn.openlaszlo.org/openlaszlo/trunk
>
> Summary: Fix IE memory leaks in drawview
>
> Bugs Fixed: LPP-7939 - Huge memory leak in IE7 on each reload of the  
> app
>
> Technical Reviewer: hminsky
> QA Reviewer: mdemmon
>
> Details: Tucker fund an updated memory leak checker that pinpointed  
> a couple of properties in drawview (one in excanvas) that were  
> causing apps to leak.
>
> Implemented destroy() to clean up after the canvas, added instance  
> to LzSprite.prototype.__sprites hash so IE cleans up onbeforeunload  
> - see LzSprite.js for more.
>
> Tests: test/extensions/drawing.lzx?lzr=dhtml&lzt=html (and webtop)  
> show no leaks with the leak detector from M$, found at http://blogs.msdn.com/gpde/pages/javascript-memory-leak-detector.aspx
>
> Files:
> M      lps/components/extensions/drawview.lzx
>
> Changeset: http://svn.openlaszlo.org/openlaszlo/patches/20090522-maxcarlson-9.tar