[Laszlo-dev] For Review: Change 20090602-sallen-N Summary: added independed scrubber and progress components

[Sarah Allen]

Oh, right.  I'll take a look at that later this week.

On Jun 16, 2009, at 6:53 AM, P T Withington wrote:

> The class list is generated automatically, but the categorized list  
> is maintained by hand.  I am pretty sure you have to hand-edit docs/ 
> src/nav/toc.xml to get things to show up in the reference.   
> Hopefully the pattern will be obvious.
>
> Then you need to run the (excrutiatingly long) `ant doc` task, to  
> make sure that it runs without errors, otherwise it breaks the build.
>
> On 2009-06-16, at 02:45EDT, Sarah Allen wrote:
>
>> checked in  r14147... would be nice if it was part of 4.4.  When do  
>> you expect to have an RC?
>>
>> btw:  the new components didn't show up in the reference, I added  
>> to library.lzx and auto-include, but I figured it was better to  
>> have them in and no worse than the other undocumented  
>> components :)   Let me know the secret to the reference toc and  
>> I'll fix it up.
>>
>> Thanks,
>> Sarah
>>
>> On Jun 15, 2009, at 4:08 PM, Max Carlson wrote:
>>
>>> Please check this in soon, and send a merge proposal if you want  
>>> it as part of 4.4!  Just a heads up.  I hope you're well!
>>>
>>> Sarah Allen wrote:
>>>> On Jun 2, 2009, at 6:00 PM, Max Carlson wrote:
>>>>> This change to mediastream.lzx looks like a typo:
>>>>>     //Debug.warite("mediastream._updateTime time=%w mode=%w  
>>>>> paused=%w",
>>>>>     //   this.time, this.mode, this.paused);
>>>> so it does
>>>>>
>>>>>
>>>>> Also, I'm not sure it's a good idea to remove these from the  
>>>>> autoincludes:
>>>>>
>>>>> videoscreen: av/videoscreen.lzx
>>>>> videoslider: av/videoslider.lzx
>>>>> videothumbnail: av/videothumbnail.lzx
>>>>> videotogglebutton: av/videotogglebutton.lzx
>>>> the issue is that those are effectively private to the YouTube  
>>>> demo.  They aren't documented or tested that I know of.  Do we  
>>>> really want them auto-included?
>>>>>
>>>>>
>>>>> Otherwise, approved!
>>>>>
>>>>>
>>>>> Sarah Allen wrote:
>>>>>> Max -- here's the changeset again with the missing file.  Sorry  
>>>>>> about that!
>>>>>> Change 20090602-sallen-N by sallen at sallen-mac.local on  
>>>>>> 2009-06-02 17:47:32 PDT
>>>>>> in /Users/sarah/src/svn/openlaszlo/trunk
>>>>>> for http://svn.openlaszlo.org/openlaszlo/trunk
>>>>>> Summary: added independed scrubber and progress components
>>>>>> New Features: new components designed for use with videoview
>>>>>> Bugs Fixed:
>>>>>> Technical Reviewer: max
>>>>>> QA Reviewer: (pending)
>>>>>> Doc Reviewer: (pending)
>>>>>> Documentation: components documented inline, should show up in  
>>>>>> reference
>>>>>> Release Notes:
>>>>>> Details: These compnents allow you to create your own video  
>>>>>> player that has a different layout.  I feel like the  
>>>>>> videoplayer component should be updated to use these, but there  
>>>>>> is a feature they don't support (showing the amount of buffer)  
>>>>>> which you can see in the YouTube demo.  Since I can't test that  
>>>>>> feature outside of the YouTube app, I can't really implement it.
>>>>>> * videoview onstream event wasn't sent when stream created by URL
>>>>>> * mediastream: fixes to seek/pause behavior (revealed by work  
>>>>>> on the scrubber)
>>>>>> Tests: test-scrubber.lzx
>>>>>> Files:
>>>>>> A      test/video/test-scrubber.lzx
>>>>>> A      test/video/resources
>>>>>> A      test/video/resources/gradient.png
>>>>>> M      WEB-INF/lps/misc/lzx-autoincludes.properties
>>>>>> M      lps/components/extensions/av/mediastream.lzx
>>>>>> M      lps/components/extensions/av/videoview.lzx
>>>>>> M      lps/components/extensions/av/rtmpconnection.lzx
>>>>>> A      lps/components/av/streamscrubber.lzx
>>>>>> A      lps/components/av/streamprogress.lzx
>>>>>> Changeset: http://svn.openlaszlo.org/openlaszlo/patches/20090602-sallen-N.tar
>>>>>> http://www.ultrasaurus.com
>>>>>
>>>>> -- 
>>>>> Regards,
>>>>> Max Carlson
>>>>> OpenLaszlo.org
>>>> http://www.ultrasaurus.com
>>>
>>> -- 
>>> Regards,
>>> Max Carlson
>>> OpenLaszlo.org
>>
>> http://www.ultrasaurus.com
>>
>>
>>
>

http://www.ultrasaurus.com