[Laszlo-dev] For Review: Change 20090615-Philip-8 Summary: DHTML IE: Fix context menus on text

Max Carlson max at laszlosystems.com
Mon Jun 15 13:04:39 PDT 2009


Yes, this fixes the issue in webtop.  Can you wrap the fix in a quirk so 
we can track this behavior more easily?  Otherwise, approved!

promanik at laszlosystems.com wrote:
> Change 20090615-Philip-8 by Philip at Philip-DC on 2009-06-15 13:30:14 EDT
>     in /cygdrive/f/laszlo/svn/src/svn/openlaszlo/trunk
>     for http://svn.openlaszlo.org/openlaszlo/trunk
> 
> Summary: DHTML IE: Fix context menus on text
> 
> New Features:
> 
> Bugs Fixed: LPP-8254
> 
> Technical Reviewer: andre
> QA Reviewer: max
> Doc Reviewer: (pending)
> 
> Documentation:
> 
> Release Notes:
> 
> Details:
> On the first call to document.elementFromPoint() in IE, it returns the 
> scrolldiv created in LzTextSprite. As a result, the checks for context 
> menu stopped (because the swf8mode checks were true).
> 
> The fix is to add another conditional to see if the returned element is 
> the scrolldiv. If so, ignore it and document.elementFromPoint() will be 
> called a second time to return the desired element.
> 
> Max: Does this fix webtop?
> 
> 
> Tests:
> See lpp-8254. Right clicking on text displays context menu in IE7/IE8. 
> It continues to work in FF/Safari.
> 
> Files:
> M      WEB-INF/lps/lfc/kernel/dhtml/LzMouseKernel.js
> 
> Changeset: 
> http://svn.openlaszlo.org/openlaszlo/patches/20090615-Philip-8.tar

-- 
Regards,
Max Carlson
OpenLaszlo.org


More information about the Laszlo-dev mailing list