[Laszlo-dev] For Review: Change 20090609-ptw-V Summary: Clear stuck keys on browser focus

[Max Carlson]

I'm concerned about this line being removed from 
embednew.js#_broadcastMethod():
             if (! app.loaded) continue;

We should really consider implementing callMethod for DHTML - it would 
simplify this a lot...

Otherwise, approved!
P T Withington wrote:
> Change 20090609-ptw-V by ptw at dueling-banjos.local on 2009-06-09 16:28:34 
> EDT
>     in /Users/ptw/OpenLaszlo/4.2
>     for http://svn.openlaszlo.org/openlaszlo/branches/4.2
> 
> Summary: Clear stuck keys on browser focus
> 
> Bugs Fixed: LPP-8056  Alt tab issue when switching tasks (partial)
> 
> Technical Reviewer: max (pending)
> QA Reviewer: aalappat at laszlosystems.com (pending)
> 
> Details:
>     This fixes the bug in all browsers _except_ IE, where it only
>     reduces the bug somewhat.  I'm putting in this partial fix just so
>     the work is not lost.
> 
>     LzKeyboardKernel.*:  Add an __allKeysUp call that will simulate
>     key up events for any keys that the kernel believes to (still) be
>     down.
> 
>     LzKeys: __allKeysUp exported so it can be called from lz.embed
> 
>     embednew: When the browser regains focus, invoke
>     lz.Keys.__allKeysUp to clear any keys that may appear to still be
>     down because the browser lost focus due to keyboard input.
> 
> Tests:
>     Test case from the bug report
> 
> Files:
> M      WEB-INF/lps/lfc/kernel/swf/LzKeyboardKernel.as
> M      WEB-INF/lps/lfc/kernel/dhtml/LzKeyboardKernel.js
> M      WEB-INF/lps/lfc/kernel/swf9/LzKeyboardKernel.as
> M      WEB-INF/lps/lfc/services/LzKeys.lzs
> M      lps/includes/source/embednew.js
> 
> Changeset: http://svn.openlaszlo.org/openlaszlo/patches/20090609-ptw-V.tar

-- 
Regards,
Max Carlson
OpenLaszlo.org