[Laszlo-dev] For Review: Change 20090602-bargull-GPN Summary: DHTML: add "updateControlKeys" to LzKeyboardKernel

[Henry Minsky]

Approved. Max may have some other comments but go ahead and check in.

On Tue, Jun 2, 2009 at 1:31 PM, André Bargull <andre.bargull at udo.edu> wrote:

> So, it is ok to check in the change?
>
>
> On 6/2/2009 5:03 PM, Henry Minsky wrote:
>
>> Well, that change fixes the bug I was seeing in Safari where the downkeys
>> array would fill up with key codes.
>>
>>
>>
>> On Tue, Jun 2, 2009 at 10:37 AM, André Bargull <
>> andre.bargull at uni-dortmund.de <mailto:andre.bargull at uni-dortmund.de>>
>> wrote:
>>
>>    Hm, there is _no_ issue, just too much concurrent changes on my
>>    local machine. Sorry for that!
>>
>>
>>
>>    On 6/2/2009 4:33 PM, André Bargull wrote:
>>
>>        Ups, there is still an issue somewhere. (I shouldn't compile
>>        the debug-lfc and test an application in non-debug mode :-P  )
>>
>>
>>        On 6/2/2009 4:27 PM, André Bargull wrote:
>>
>>            These are just the changes for LzKeyboardKernel. We still
>>            need to decide whether "updateControlKeys()" needs to
>>            handle the 'metaKey' for LPP-8210.
>>
>>
>>            Change 20090602-bargull-GPN by bargull at dell--p4--2-53 on
>>            2009-06-02 15:54:52
>>            in /home/Admin/src/svn/openlaszlo/trunk
>>            for http://svn.openlaszlo.org/openlaszlo/trunk
>>
>>            Summary: DHTML: add "updateControlKeys" to LzKeyboardKernel
>>
>>            New Features:
>>
>>            Bugs Fixed: LPP-8218 - DHTML: issues with contextmenu
>>            onmenuopen, dragging (partial)
>>
>>            Technical Reviewer: max, ptw
>>            QA Reviewer: hqm
>>            Doc Reviewer: (pending)
>>
>>            Documentation:
>>
>>            Release Notes:
>>
>>            Details:
>>            Call "updateControlKeys()" instead of "__keyboardEvent()"
>>            for mouse-events.
>>            Set "cancelBubble" and "returnValue" after invoking
>>            "updateControlKeys()" to mimic old behaviour (this is
>>            actually wrong, see LPP-8200, but reduces testing effort
>>            right now). "keyCode" is set to 0 for mouse-events in IE,
>>            Opera, Safari, so you only need to test for keyCode==0
>>            (Firefox is irrelevant in this case, because it sets
>>            keyCode to `undefined` for mouse-events).
>>
>>
>>
>>            Tests:
>>            test/lfc/legals/keyboardandmouse.lzx?lzr=dhtml still works
>>            as expected
>>
>>
>>            Files:
>>            M WEB-INF/lps/lfc/kernel/dhtml/LzKeyboardKernel.js
>>            M WEB-INF/lps/lfc/kernel/dhtml/LzSprite.js
>>            M WEB-INF/lps/lfc/kernel/dhtml/LzMouseKernel.js
>>
>>            Changeset:
>>
>> http://svn.openlaszlo.org/openlaszlo/patches/20090602-bargull-GPN.tar
>>
>>
>>
>>
>>
>>
>> --
>> Henry Minsky
>> Software Architect
>> hminsky at laszlosystems.com <mailto:hminsky at laszlosystems.com>
>>
>>
>>


-- 
Henry Minsky
Software Architect
hminsky at laszlosystems.com
-------------- next part --------------
An HTML attachment was scrubbed...
URL: http://www.openlaszlo.org/pipermail/laszlo-dev/attachments/20090602/016506c4/attachment.html