[Laszlo-dev] For Review: Change 20081029-ptw-E Summary: Make sure queued play actions apply to constrained resources

[P T Withington]

It seems to me the logic here is terribly rotten, and probably a  
holdover from swf5 days when it was much harder to manipulate movie  
clips at runtime (in swf5 you could not create an empty clip, you had  
to have an empty resource that you kept around and cloned).

What a mess.

getMCRef in a not-load-transformed view is guaranteed to never return  
null, but in a load-transformed view returns null if the resource is  
not yet loaded.  IWBNI this were more consistent.

I'm reopening the bug with a fuller test case (which currently will  
hang...)  Bleah.

On 2008-10-30, at 02:22EDT, André Bargull wrote:

>
> On 10/30/2008 12:50 AM, P T Withington wrote:
>> Uh-oh, already checked in.  So you are saying I need to check `(mc  
>> == null) || __LZhaser`?  If I make that change, do you approve?
>
> As I said, I think the `__LZhaser` flag is always true for http- 
> resources, so that condition won't be help.
>
> From "LzMakeLoadSprite.transform(..)":
>> if (v.__LZmovieClipRef == null || ! v.__LZhaser) {
>>   //the view doesn't have the empty resource. We need to try and  
>> replace it
>>   v.makeContainerResource();
>> }
>
>
>> Don't get me started on LzMakeLoadSprite.  I really wonder if there  
>> is a better way...
>> On 2008-10-29, at 19:05EDT, André Bargull wrote:
>>> Not approved.
>>> "getMCRef()" returns `null` for http-resources which are still  
>>> loading. So "if (m == null)" did handle that case, and I think the  
>>> "__LZhaser"-flag is also always set to `true` for http-resources.  
>>> See LzMakeLoadSprite for more on this topic. (You don't need to  
>>> say that LzMakeLoadSprite is..., hmm "interesting"?  :-) )
>>>
>>>> Change 20081029-ptw-E by ptw at dueling-banjos.home <http://www.openlaszlo.org/mailman/listinfo/laszlo-dev 
>>>> > on 2008-10-29  15:44:33 EDT
>>>>    in /Users/ptw/OpenLaszlo/trunk-2
>>>>    for http://svn.openlaszlo.org/openlaszlo/trunk
>>>>
>>>> Summary: Make sure queued play actions apply to constrained  
>>>> resources
>>>>
>>>> Bugs Fixed:
>>>> LPP-5338  LzView play attribute doesn't work as advertised. (swf8)
>>>>
>>>> Technical Reviewer: max (pending)
>>>> QA Reviewer: mdemmon (pending)
>>>>
>>>> Details:
>>>>    If play/stop on an empty clip, queue.  If queued actions on
>>>>    setResource, drain the queue.
>>>>
>>>> Tests:
>>>>    Test case from bug now works correctly in swf8.
>>>>
>>>> Files:
>>>> M      WEB-INF/lps/lfc/kernel/swf/LzSprite.as
>>>>
>>>> Changeset: http://svn.openlaszlo.org/openlaszlo/patches/20081029-ptw-E.tar
>>>>
>>>
>