[Laszlo-dev] For Review: Change 20081026-maxcarlson-v Summary: Back out change to make swf9 sprite static instead of dynamic

Max Carlson max at openlaszlo.org
Mon Oct 27 10:18:24 PDT 2008


Agreed - I'm going to change it back just for this release - we'll go 
back to a static class (and sort out the implications) after this release...

André Bargull wrote:
> Do we really need to make LzSprite dynamic? Because we should care about 
> performance benefits for static classes.
> 
> In both cases, LzSprite isn't actually required to be dynamic:
> The code in drawview ("clearMask()") won't ever work for swf9, because 
> "__LZmaskClip" is an internal member in the swf8-sprite, for swf9 it's 
> rather "mask" resp. "masksprite".
> And in videoview, the `video` should be stored in the view itself 
> instead of the sprite, so you can also unify the different 
> implementations for "_getflashvideo()".
> 
> On 10/27/2008 3:02 AM, Max Carlson wrote:
>> Change 20081026-maxcarlson-v by maxcarlson at Bank on 2008-10-26 18:55:57 
>> PDT
>>     in /Users/maxcarlson/openlaszlo/trunk-clean
>>     for http://svn.openlaszlo.org/openlaszlo/trunk
>>
>> Summary: Back out change to make swf9 sprite static instead of dynamic
>>
>> Bugs Fixed: LPP-7245 - swf9: drawview failing to compile, LPP-7246 - 
>> swf9: youtube failing to compile
>>
>> Technical Reviewer: andre.bargull at udo.edu
>> QA Reviewer: promanik
>>
>> Details: Make swf9 sprites dynamic again so drawview and videoview 
>> compile again in swf9.
>>
>> Tests: See LPP-7245, LPP-7246
>>
>> Files:
>> M      WEB-INF/lps/lfc/kernel/swf9/LzSprite.as
>>
>> Changeset: 
>> http://svn.openlaszlo.org/openlaszlo/patches/20081026-maxcarlson-v.tar
>>
> 

-- 
Regards,
Max Carlson
OpenLaszlo.org



More information about the Laszlo-dev mailing list