[Laszlo-dev] For Review: Change 20081026-maxcarlson-v Summary: Back out change to make swf9 sprite static instead of dynamic

André Bargull andre.bargull at udo.edu
Mon Oct 27 07:07:58 PDT 2008


Do we really need to make LzSprite dynamic? Because we should care about 
performance benefits for static classes.

In both cases, LzSprite isn't actually required to be dynamic:
The code in drawview ("clearMask()") won't ever work for swf9, because 
"__LZmaskClip" is an internal member in the swf8-sprite, for swf9 it's 
rather "mask" resp. "masksprite".
And in videoview, the `video` should be stored in the view itself 
instead of the sprite, so you can also unify the different 
implementations for "_getflashvideo()".

On 10/27/2008 3:02 AM, Max Carlson wrote:
> Change 20081026-maxcarlson-v by maxcarlson at Bank on 2008-10-26 18:55:57 PDT
>     in /Users/maxcarlson/openlaszlo/trunk-clean
>     for http://svn.openlaszlo.org/openlaszlo/trunk
> 
> Summary: Back out change to make swf9 sprite static instead of dynamic
> 
> Bugs Fixed: LPP-7245 - swf9: drawview failing to compile, LPP-7246 - 
> swf9: youtube failing to compile
> 
> Technical Reviewer: andre.bargull at udo.edu
> QA Reviewer: promanik
> 
> Details: Make swf9 sprites dynamic again so drawview and videoview 
> compile again in swf9.
> 
> Tests: See LPP-7245, LPP-7246
> 
> Files:
> M      WEB-INF/lps/lfc/kernel/swf9/LzSprite.as
> 
> Changeset: 
> http://svn.openlaszlo.org/openlaszlo/patches/20081026-maxcarlson-v.tar
> 



More information about the Laszlo-dev mailing list