[Laszlo-dev] For Review: Change 20081026-ptw-B Summary: basegridrow needs to import basecomponent
P T Withington
ptw at pobox.com
Mon Oct 27 06:41:02 PDT 2008
I can't tell. This is obviously a regression, since this stuff used
to work. While I don't like magic, with explicit includes, developers
are liable to include things 'just to be safe' even though they might
not be needed, so maybe explicit includes are bad. Something must
have changed to make the auto-include mechanism not recurse into
libraries that are auto-included. I still plan to dig in to that.
On 2008-10-26, at 22:06EDT, Max Carlson wrote:
> I noticed the video components didn't work without explicit includes
> a while back...
> It seems like a good thing to have explicit includes for components
> as far as overall weight is concerned. It forces the developer to
> only include what they need.
> P T Withington wrote:
>> I plan to check this in pre-freeze. We should discuss whether
>> components are allowed to have implicit includes.
>> Change 20081026-ptw-B by ptw at dueling-banjos.home on 2008-10-26
>> 21:07:32 EDT
>> in /Users/ptw/OpenLaszlo/trunk-2
>> for http://svn.openlaszlo.org/openlaszlo/trunk
>> Summary: basegridrow needs to import basecomponent
>> Bugs Fixed:
>> LPP-6555 Implicit include of a basecomponent stopped working.
>> Technical Reviewer: a.bargull at intensis.de (pending)
>> QA Reviewer: max (pending)
>> Add explicit include of basecomponent in basegridrow
>> Test case from bug
>> M lps/components/base/basegridrow.lzx
>> Changeset: http://svn.openlaszlo.org/openlaszlo/patches/20081026-ptw-B.tar
> Max Carlson
More information about the Laszlo-dev