[Laszlo-dev] [Laszlo-checkins] r11453 - openlaszlo/trunk/WEB-INF/lps/lfc/controllers

P T Withington ptw at pobox.com
Thu Oct 16 13:05:50 PDT 2008


Agreed.  But the 'diff' that gets sent with a review is not as smart.   
Maybe we should just tell the diff to ignore whitespace too.  Oh, I  
think we did not originally because there was a lot of Python in the  
code base.

On 2008-10-16, at 14:36EDT, André Bargull wrote:

> Hmm, I'm using WinMerge to inspect my diffs and WinMerge has got an  
> option to ignore all whitespace changes. This makes it pretty easy  
> for me to focus on real changes.
>
>
>> On 2008-10-15, at 04:37EDT, bargull at openlaszlo.org <http://www.openlaszlo.org/mailman/listinfo/laszlo-dev 
>> > wrote:
>>
>> >/ (And did some work for the all-time favourite LPP-2623.)
>> /
>> When we did the 'class conversion' Phil intentionally did not re-  
>> indent the code to make it easier for reviewers to see what  
>> changes  had been made.
>>
>> I was thinking it would be great to go through the whole code base  
>> and  re-indent (with no algorithmic changes) at some point.
>>
>




More information about the Laszlo-dev mailing list