[Laszlo-dev] For Review: Change 20081009-ptw-U Summary: Trim some class fat

[André Bargull]

Ok, I still need to do my qa-part, but I think the change is safe, so 
I'd say approved.

On 10/9/2008 11:37 PM, P T Withington wrote:
> Thank you.  I fixed that and updated the changeset.  Approved?
> 
> On 2008-10-09, at 17:26EDT, André Bargull wrote:
> 
>> One question concerning your change in 
>> "CommonGenerator#visitClassDefinition(SimpleNode, SimpleNode[])":
>>
>>>  SimpleNode stmtNode = (new Compiler.Parser()).substitute(node,
>>> -   "(function () { with("+globalprefix+"_1"+")"+
>>> -   "with("+globalprefix+"_1.prototype) { _5 }})()",
>>> +   "(function ($lzsc$c) { with("+globalprefix+"$lzsc$c"+")"+
>>> +   "with("+globalprefix+"$lzsc$c.prototype) { _5 }})(_1)",
>>>    map);
>> I thought it needs to be like so, because "globalprefix" may be 
>> "_level0." when compiling a swf8 loadable library.
>>
>>> SimpleNode stmtNode = (new Compiler.Parser()).substitute(node,
>>>    "(function ($lzsc$c) { with($lzsc$c)"+
>>>    "with($lzsc$c.prototype) { _5 }})("+globalprefix+"_1)",
>>>    map);
>>
>>
>>
>> On 10/9/2008 8:35 PM, P T Withington wrote:
>>> Change 20081009-ptw-U by ptw at dueling-banjos.local on 2008-10-09 
>>> 13:19:51 EDT
>>>    in /Users/ptw/OpenLaszlo/honey-dew
>>>    for http://svn.openlaszlo.org/openlaszlo/trunk
>>>
>>> Summary: Trim some class fat
>>>
>>> Bugs Fixed:
>>> LPP-6718  "Class.make()" can be minimized
>>>
>>> Technical Reviewer: dda (pending)
>>> QA Reviewer: a.bargull at intensis.de (pending)
>>>
>>> Details:
>>>    CommonGenerator: Use a lambda to do CSE.
>>>
>>>    ClassModel: Resurrect the part of the attributes optimization that
>>>    works.
>>>
>>> Tests:
>>>    Smokecheck, inspect compiler output for:
>>>      <class name="pak" extends="button" />
>>>    is 2k smaller.
>>>
>>> Files:
>>> M      WEB-INF/lps/server/src/org/openlaszlo/sc/CommonGenerator.java
>>> M      WEB-INF/lps/server/src/org/openlaszlo/compiler/ClassModel.java
>>>
>>> Changeset: 
>>> http://svn.openlaszlo.org/openlaszlo/patches/20081009-ptw-U.tar
>>>
> 
>