[Laszlo-dev] For Review: Change 20081002-maxcarlson-s Summary: Add playback control for loaded movieclips

[André Bargull]

- In SoundMC.as, was "_fps" set to 30 to match "canvas.framerate" or was 
there any other reason?
- In "LzSprite#setSource()", you need to set "__isinternalresource" 
after calling "unload()", or "__isinternalresource" will be set to ´null´.
- The ´EVENT.ENTER_FRAME´ event-listener should be unregistered in 
"unload()", because swf9 is not really good at resource-management. [1]

And there is a bug:
If you reset the source with: audioplayer.setSource("logo_cs3.swf")
you'll get two "onlastframe"-events. I guess this should be resolved by 
removing the event-listener in "unload()".


Otherwise approved.


[1] http://www.gskinner.com/blog/archives/2006/07/as3_resource_ma_1.html


On 10/3/2008 4:28 AM, Max Carlson wrote:
> Change 20081002-maxcarlson-s by maxcarlson at Bank on 2008-10-02 19:21:11 PDT
>     in /Users/maxcarlson/openlaszlo/trunk-clean
>     for http://svn.openlaszlo.org/openlaszlo/trunk
> 
> Summary: Add playback control for loaded movieclips
> 
> Bugs Fixed: LPP-6914 - Make playback controls work for swf9 animations
> 
> Technical Reviewer: andre.bargull at udo.edu
> QA Reviewer: promanik
> Doc Reviewer: (pending)
> 
> Details: LzSoundMC.as - Use canvas.framerate instead of hardcoded value.
> 
> LzSprite.as - Add __isinternalresource to track whether an internal 
> resource is loaded.  Warn if the loaded movie is an AVM1Movie and won't 
> support playback controls.  Otherwise, store a reference to the loader 
> movieclip.  Add updateFrames() method to handle frame updates.  Update 
> play() and stop() to deal with internal resources, loaded movieclips, 
> and streaming audio appropriately.
> 
> Tests: Testcase at LPP-6914 runs consistently in swf8 and swf9.
> 
> Files:
> M      WEB-INF/lps/lfc/kernel/swf/LzSoundMC.as
> M      WEB-INF/lps/lfc/kernel/swf9/LzSprite.as
> 
> Changeset: 
> http://svn.openlaszlo.org/openlaszlo/patches/20081002-maxcarlson-s.tar
>