[Laszlo-dev] For Review: Change 20081125-laszlo-0 Summary: Update deprecated method in LzUnit example 4

[P T Withington]

Yes. Approved.

On Nov 26, 2008, at 3:10, J Crowley <jcrowley at laszlosystems.com> wrote:

> So is this approved if I change it to what you suggested?
>
> P T Withington wrote:
>> Actually, in the LFC proper, you could call the setter method  
>> directly, rather than using setAttribute, just for efficiency:
>>
>>  cn.$lzc$set_data(val);
>>
>> [adding Phil]
>>
>> Phil:  I'm concerned that in LzNode, $lzc$set_data is calling  
>> setData.  Was this an oversight in the grand setter conversion?   
>> Luckily Josh is not hitting that (apparently because LzDatapointer  
>> overrides both $lzc$set_data and setData).
>>
>> On 2008-11-25, at 08:35EST, J Crowley wrote:
>>
>>> Change 20081125-laszlo-0 by laszlo at T43-L3XEXMW on 2008-11-25  
>>> 08:18:22 EST
>>> in /home/laszlo/src/svn/openlaszlo/trunk-grayfox
>>> for http://svn.openlaszlo.org/openlaszlo/trunk
>>>
>>> Summary: Update deprecated method in LzUnit example 4
>>>
>>> New Features:
>>>
>>> Bugs Fixed: LPP-7199 - Update deprecated method in LzUnit example 4
>>>
>>> Technical Reviewer: max
>>> QA Reviewer: ptw
>>> Doc Reviewer: (pending)
>>>
>>> Documentation:
>>>
>>> Release Notes:
>>>
>>> Details: Changed cn.setData( val ) to
>>> cn.setAttribute('data', val ) in LzDatapointer.lzs
>>> to bring the code up to date and eliminate the
>>> warning.
>>>
>>> Tests: Run docs/src/developers/programs/lzunit-$4.lzx
>>> There should be no warnings about using deprecated
>>> setData(), and it should still work.
>>>
>>> Files:
>>> M WEB-INF/lps/lfc/data/LzDatapointer.lzs
>>>
>>> Changeset: http://svn.openlaszlo.org/openlaszlo/patches/20081125-laszlo-0.tar
>>>
>>>
>>
>>
>
>