[Laszlo-dev] For Review: Change 20081125-ptw-g Summary: Fix leak-detection rot in DHTML

P T Withington ptw at pobox.com
Tue Nov 25 05:46:56 PST 2008


[I plan to check this in ahead of review -- what's the worst that  
could happen?]

Change 20081125-ptw-g by ptw at dueling-banjos.home on 2008-11-25  
08:32:03 EST
     in /Users/ptw/OpenLaszlo/trunk
     for http://svn.openlaszlo.org/openlaszlo/trunk

Summary: Fix leak-detection rot in DHTML

Bugs Fixed:
LPP-7382  extreme slow performance on IE7 as compared with FF3 on  
DHTML (in support of debugging it)

Technical Reviewer: max (pending)

Details:
     LzDebug: Use an a-list for singleEscapeCharacters, instead of an
     object, so you don't get confused by the tracer marking the
     object.  Objects make really poor tables!

     LzMemory: Remember that native objects will be "typeof ==
     'object'" even though they are not "instanceof Object".  Re-jigger
     the try/catch in traceStep to handle errors that might be
     signalled trying to access or mark a reference.  Treat
     inaccessible, untestable, or auto-wrapping objects as marked for
     tracing purposes (there's nothing else we can do).  Use
     LzTimeKernel for timer services.

Tests:
     Ran test associated with bug in DHTML and noted that memory  
tracing gave
     non-empty results.  Not clear there is a leak, but before the fix,
     you could not tell

Files:
M      WEB-INF/lps/lfc/debugger/LzDebug.lzs
M      WEB-INF/lps/lfc/debugger/LzMemory.lzs


Changeset: http://svn.openlaszlo.org/openlaszlo/patches/20081125-ptw-g.tar


More information about the Laszlo-dev mailing list