[Laszlo-dev] For Review: Change 20081113-laszlo-4 Summary: Color example 3 gives warnings.

[J Crowley]

P.S. - I can check in your change if you'd like, since I already have 
the changeset prepared and have modified my color-$3.lzx file to your 
version in order to check it out.

P T Withington wrote:
> I like your idea of putting the text in the view but, I gotta through 
> my 2p. in here.  First, calling #0000ff 'rgb' is broken, we need to 
> fix up the names.  And rather than describing each one in the 
> debugger, let's make them self-describing.  And let's make it clear 
> that expressions can be anything at all, they don't have to be hex 
> constants. Finally, let's make use of the nifty 
> Debug.explainStyleBindings, just for show.  Here's my cut at what this 
> demo should look like:
>
>
>
>
> Oh, and the fact that the text color is wrong in swf8 is a bug.  
> Please file...
>
> On 2008-11-13, at 08:14EST, Lou Iorio wrote:
>
>> I've never fully understood this example, and I think it's far more 
>> complicated than it has to be.
>>
>> For one thing, the actual text "Blue1" looks like it's being styled by
>>
>>    #tName {
>>    fgcolorName : "blue";
>>    }
>>
>>
>>    <view id="vName" height="100" width="100" 
>> bgcolor="$style{'bgcolorName'}"/>
>>    <text id="tName" font="verdana,sans-serif" fontsize="30" 
>> fontstyle="bold" height="40"
>>         fgcolor="$style{'fgcolorName'}">Blue1</text>
>>
>>
>> Indeed, the text is blue when compiled to DHTML. However, the 
>> displayed text is black in
>> both SWF8 and SWF9. The same is true of the other two examples using 
>> CSS.
>>
>> Further, since DHTML doesn't import fonts, the result when you
>> compile to DHTML wraps oddly. Simplifying the <text> fixes that problem:
>>
>>    <view id="vName" height="100" width="100" 
>> bgcolor="$style{'bgcolorName'}"/>
>>    <text id="tName" fontsize="30" 
>> fgcolor="$style{'fgcolorName'}">Blue1</text>
>>
>> I also think it would be more clear if <text> were a child of <view> 
>> instead of a sibling so
>> the text appears in the view instead of to its right.
>>
>> Here's a simplified version of your example (again, this works in 
>> DHTML but not SWF):
>>
>>
>> <color-$3.lzx>
>>
>>
>> If I'm wrong about this, please enlighten me.
>>
>> Lou
>>
>> On Nov 13, 2008, at 3:19 AM, J Crowley wrote:
>>
>>> Change 20081113-laszlo-4 by laszlo at T43-L3XEXMW on 2008-11-13 
>>> 02:16:21 EST
>>> in /home/laszlo/src/svn/openlaszlo/trunk-liquid
>>> for http://svn.openlaszlo.org/openlaszlo/trunk
>>>
>>> Summary: Color example 3 gives warnings.
>>>
>>> New Features:
>>>
>>> Bugs Fixed: LPP-7193 - Color example 3 gives warnings.
>>>
>>> Technical Reviewer: lou at louiorio.com
>>> QA Reviewer: ptw
>>> Doc Reviewer: (pending)
>>>
>>> Documentation:
>>>
>>> Release Notes:
>>>
>>> Details: Fixed this per Lou's recommendation,
>>> eliminating the redundant example.
>>>
>>> Tests: Run the affected file -- it should now
>>> be to specification per the comment on the
>>> bug.
>>>
>>> Files:
>>> M docs/src/developers/programs/color-$3.lzx
>>>
>>> Changeset: 
>>> http://svn.openlaszlo.org/openlaszlo/patches/20081113-laszlo-4.tar
>>>
>>>
>>
>