[Laszlo-dev] For Review: Change 20080126-bargull-6 Summary: Use delegate-id to identify delegate in LzTimer

[André Bargull]

Change 20080126-bargull-6 by bargull at dell--p4--2-53 on 2008-01-26 16:43:10
in /home/Admin/src/svn/openlaszlo/trunk
for http://svn.openlaszlo.org/openlaszlo/trunk

Summary: Use delegate-id to identify delegate in LzTimer

New Features:

Bugs Fixed: LPP-5379 - "LzTimer never stops calling delegate if called 
object's toString() value changes"

Technical Reviewer: ptw
QA Reviewer: promanik
Doc Reviewer: (pending)

Documentation:

Release Notes:

Details:
As described by the bug-reporter, if the return-value of the context's 
"toString"-method changed, the delegate won't be removed from LzTimer. 
This happens because a delegate itself is used as the key for the 
LzTimer's "timerList", or better the string-representation of the 
delegate -> which is the return value of the delegate's 
"toString"-method. But the "toString"-method also depends on the 
context's "toString"-method. And I guess I don't need to underline that 
this may cause several errors for components like ...
However, to fix this bug, the delegates are now identified by their 
delegate-id in the "timerList".


Tests:
see bugreport

Files:
M WEB-INF/lps/lfc/services/LzTimer.lzs

Changeset: 
http://svn.openlaszlo.org/openlaszlo/patches/20080126-bargull-6.tar