[Laszlo-dev] For Review: Change 20071220-maxcarlson-2, Summary: Fix enable/disabling of delegates bound to lztimer
a.bargull at intensis.de
Thu Jan 3 10:23:42 PST 2008
And this change ignores the "__LZdeleted"-flag, which may lead to memory
> Not Approved.
> 1) If enabled/disabled is part of the protocol of delegates, it should
> be enforced by LzDelegate#execute. If you don't want to fix that as
> part of this, please file a bug.
> 2) Please add a comment to your change saying that you are hand-
> inlining LzDelegate#execute
> 3) Please add a cross-reference to LzDelegate#execute noting that it
> is hand-inlined in LzTimerClass#addTimer (so changes to execute must
> be propagated there). Until we have inlining in the compiler, we
> _have_ to do this manual bookkeeping to prevent drift.
> On 2007-12-20, at 11:56 EST, Max Carlson wrote:
>> > Change 20071220-maxcarlson-2 by maxcarlson at Roboto on 2007-12-20
>> > 08:55:16 PST
>> > in /Users/maxcarlson/openlaszlo/trunk
>> > for http://svn.openlaszlo.org/openlaszlo/trunk
>> > Summary: Fix enable/disabling of delegates bound to lztimer
>> > New Features:
>> > Bugs Fixed: LPP-5302 - LzTimer ignores disabled events
>> > Technical Reviewer: promanik
>> > QA Reviewer: ptw
>> > Doc Reviewer: (pending)
>> > Documentation:
>> > Release Notes:
>> > Details: Use code from LzDelegate.sendEvent() to properly handle
>> > disabled delegates.
>> > Tests: See LPP-5302.
>> > Files:
>> > M WEB-INF/lps/lfc/services/LzTimer.lzs
>> > Changeset: http://svn.openlaszlo.org/openlaszlo/patches/20071220-maxcarlson-2.tar
More information about the Laszlo-dev