[Laszlo-dev] For Review: Change 20080429-maxcarlson-o Summary: Fix "Sent extra global mouse event" warnings in swf and dhtml event sending
a.bargull at intensis.de
Wed Apr 30 09:49:27 PDT 2008
Additionally to that one, there is one minor glitch in LzModeManager
you cannot access the static member "WAIT_FOR_CLICK" through "this",
so either drop static or use "LzModeManagerClass.WAIT_FOR_CLICK".
Otherwise all approved!
On 4/30/2008 2:43 PM, Philip Romanik wrote:
> Approved, but you have to fix a line of code in LzModeManager so it
> builds in swf9. LzGlobalMouse.__mouseEvent() takes two arguments. I
> added the second 'me' argument to test.
> LzGlobalMouse.__mouseEvent('onmousemove', me);
>> Change 20080429-maxcarlson-o by maxcarlson at Roboto on 2008-04-29
>> 18:16:29 PDT
>> in /Users/maxcarlson/openlaszlo/trunk-clean
>> for http://svn.openlaszlo.org/openlaszlo/trunk
>> Summary: Fix "Sent extra global mouse event" warnings in swf and
>> dhtml event sending
>> New Features:
>> Bugs Fixed: LPP-5461 - DHTML "LzModeManager.handleMouseEvent" gets
>> "onmousemove"-events, LPP-58770- SWF "Sent extra global mouse event"
>> Technical Reviewer: a.bargull at intensis.de
>> <mailto:a.bargull at intensis.de> QA Reviewer: promanik Doc Reviewer:
>> Release Notes:
>> Details: LzSprite.js - Explicitly set __lastMouseDown to null if the
>> mouse goes up in the same sprite it want down on.
>> LzMouseKernel.js - Catch bubbled onmouseup events early to avoid
>> sending an extra callback if __lastMouseDown != null.
>> LzModeManager.as - Fix bad initialization of WAIT_FOR_CLICK constant.
>> LzModeManager.lzs - Delegate 'onmousemove' events to LzGlobalMouse.
>> Otherwise, send the event through the mouse manager.
>> Tests: The last testcase in LPP-5461 shows no additional 'onmouseup'
>> event or 'onmousemove' events in dhtml. Behavior is consistent
>> between dhtml and swf. test/lfc/legals/keyboardandmouse.lzx passes
>> in swf and dhtml. Both show far fewer 'Sent extra global mouse event"
>> warnings in swf with the debugger on.
>> M WEB-INF/lps/lfc/kernel/dhtml/LzSprite.js
>> M WEB-INF/lps/lfc/kernel/dhtml/LzMouseKernel.js
>> M WEB-INF/lps/lfc/services/platform/swf/LzModeManager.as
>> M WEB-INF/lps/lfc/services/LzModeManager.lzs
More information about the Laszlo-dev