[Laszlo-dev] For Review: Change 20080423-Philip-8. Summary: Unify LzContextMenu across runtimes

[Max Carlson]

Approved!  I used a simpler scheme with class overrides for 
LzModeManager - this looks a bit better because _everything_ is isolated 
to the kernel.

Philip Romanik wrote:
> Change 20080423-Philip-8 by Philip at Philip-DC on 2008-04-23 20:02:24 EDT
>     in /cygdrive/f/laszlo/svn/src/svn/openlaszlo/trunk
>     for http://svn.openlaszlo.org/openlaszlo/trunk
> 
> Summary: Unify LzContextMenu across runtimes
> 
> New Features:
> 
> Bugs Fixed: LPP-5845
> 
> Technical Reviewer: max
> QA Reviewer: (pending)
> Doc Reviewer: (pending)
> 
> Documentation:
> 
> Release Notes:
> 
> Details:
> Added /services/LzContextMenu.lzs as the interface for all runtimes. 
> They call to LzContextMenuKernel classes in /kernel/*/. The sprite or 
> mouse kernel used to access LzContextMenu. This is changed to call the 
> kernel.
> 
> There are cases where the kernel-level class needs information from 
> LzContextMenu and vise-versa.
> 
> LzContextMenu has a 'kernel' variable that points to the 
> LzContextMenuKernel or LzContextMenuItemKernel.
> LzContextMenuKernel and LzContextMenuItemKernel contain an 'owner' 
> variable that points to LzContextMenu or LzContextMenuItem.
> 
> 
> test/contextmenu/api.lzx - Modified app so only the public api is used.
> test/swf9/contextmenu.lzx - Based on api.lzx but runs in all runtimes.
> kernel/swf/LzContextMenuKernel.lzx swf-specific implementation
> kernel/swf9/LzContextMenuKernel.lzx swf9-specific implementation
> kernel/dhtml/LzContextMenuKernel.lzx dhtml-specific implementation
> 
> kernel/swf/LzSprite.as - The sprite calls into LzContextMenuKernel
> kernel/dhtml/LzMouseKernel.js - Calls into LzContextMenuKernel
> kernel/swf9/LzSprite.as - The sprite calls into LzContextMenuKernel
> 
> There is an issue in swf9 with the default context menu. See LPP-5868
> 
> 
> Tests:
> /test/contextmenu/api.lzx runs in dhtml and swf
> /test/swf9/contextmenu.lzx runs in swf/swf9/dhtml.
> 
> 
> Files:
> M      test/contextmenu/api.lzx
> A      test/swf9/contextmenu.lzx
> D      WEB-INF/lps/lfc/kernel/swf/LzContextMenu.lzs
> A      WEB-INF/lps/lfc/kernel/swf/LzContextMenuKernel.lzs
> M      WEB-INF/lps/lfc/kernel/swf/Library.lzs
> M      WEB-INF/lps/lfc/kernel/swf/LzSprite.as
> A      WEB-INF/lps/lfc/kernel/dhtml/LzContextMenuKernel.lzs
> D      WEB-INF/lps/lfc/kernel/dhtml/LzContextMenu.js
> M      WEB-INF/lps/lfc/kernel/dhtml/LzMouseKernel.js
> M      WEB-INF/lps/lfc/kernel/dhtml/Library.lzs
> D      WEB-INF/lps/lfc/kernel/swf9/LzContextMenu.lzs
> A      WEB-INF/lps/lfc/kernel/swf9/LzContextMenuKernel.lzs
> M      WEB-INF/lps/lfc/kernel/swf9/Library.lzs
> M      WEB-INF/lps/lfc/kernel/swf9/LzSprite.as
> A      WEB-INF/lps/lfc/services/LzContextMenu.lzs
> M      WEB-INF/lps/lfc/services/Library.lzs
> 
> Changeset: 
> http://svn.openlaszlo.org/openlaszlo/patches/20080423-Philip-8.tar
> 

-- 
Regards,
Max Carlson
OpenLaszlo.org