[Laszlo-dev] For Review: Change 20080412-bargull-0 Summary: update components for lzunit

[P T Withington]

Nice!  Approved.

One comment.  This is the idiom I have been using for dynamically  
created tag instances.  Maybe we should have a utility function that  
takes a tag name and does it for you:

             if (this['itemtagname'] && lz[this.itemtagname]) {
                 new lz[this.itemtagname](this, ...);
             } else if ($debug) {
                Debug.error("%s.itemtagname invalid: %s", this,  
this.itemtagname);
            }

Thus you are testing for both the tagname being set and the tagname  
being in the table of tag classes before you try to create it.

It would also be nice if we could clean up our terminology, but it it  
probably too late.  Since the LZX <class> tag actually defined a tag,  
it is too bad it was not called <tag>.  But it is really confusing in  
Javascript because what is considered a classname in LZX is a tagname  
in JS (and the JS class that implements an LZX tag has a different  
name from the tag now).

On 2008-04-12, at 12:38 EDT, André Bargull wrote:
> Both tests are working now:
>> runlzunit::
>>  BUILD SUCCESSFUL
>>  Total time: 31 minutes 16 seconds
>> lztest::
>>  BUILD SUCCESSFUL
>>  Total time: 4 minutes 9 seconds
>
>
> Change 20080412-bargull-0 by bargull at dell--p4--2-53 on 2008-04-12  
> 14:53:35
> in /home/Admin/src/svn/openlaszlo/trunk
> for http://svn.openlaszlo.org/openlaszlo/trunk
>
> Summary: update components for lzunit
>
> New Features:
>
> Bugs Fixed: LPP-5645, LPP-5710
>
> Technical Reviewer: max
> QA Reviewer: ptw
> c Reviewer: (pending)
>
> Documentation:
>
> Release Notes:
>
> Details:
> Update components, so we can run lzunit again.
>
>
> Tests:
> ant runlzunit,
> test/components/base/lzunit-baseslider.lzx,
> test/components/base/lzunit-basedatacombobox.lzx,
> testcase for LPP-5549
>
> Files:
> M lps/components/lz/basefloatinglist.lzx
> M lps/components/base/baseslider.lzx
> M lps/components/base/basedatacombobox.lzx
> M test/lzunit/testpaths.txt
>
> Changeset: http://svn.openlaszlo.org/openlaszlo/patches/20080412-bargull-0.tar
>
>