[Laszlo-dev] For Review: Change 20080411-ptw-r Summary: Restore instance attributes passed to construct methods

[Philip Romanik]

Approved!

>Change 20080411-ptw-r by 
><mailto:ptw at dueling-banjos.local>ptw at dueling-banjos.local on 2008-04-11
>17:21:45 EDT
>      in /Users/ptw/OpenLaszlo/ringding-clean
>      for 
> <http://svn.openlaszlo.org/openlaszlo/trunk>http://svn.openlaszlo.org/openlaszlo/trunk
>
>Summary: Restore instance attributes passed to construct methods
>
>Bugs Fixed:
>LPP-5732: 'Regression in Amazon @ 8592'
>LPP-5762: 'InstanceAttrs without setters'
>
>Technical Reviewer: 
><mailto:a.bargull at intensis.de>a.bargull at intensis.de (pending) QA 
>Reviewer: 
><mailto:promanik at laszlosystems.com>promanik at laszlosystems.com (pending)
>
>Details:
>      LzNode:  I think I finally understand the dance between "class
>      instance attributes" and "instance instance attributes".  The
>      attributes put in a class by the tag compiler should be installed
>      by the constructor, unless they have a setter (which the compiler
>      could not know about).  But attributes declared in an instance are
>      expected to be passed in 'args' to all construct methods, because
>      those methods may inspect/handle/modify them before they are
>      applied.  Ugly, fragile mechanism, but we must preserve it for
>      back-compatibility for the time being.  Also revert the change in
>      placement computation to look for `ignoreplacement` in attrs once
>      again.  Fix up toString and _dbg_name to work without needing
>      access to .prototype (and to print the `tagname`, not the
>      `classname`, since the user will be more familiar with the
>      tagname.
>
>      runlzunit: Run the browser in the background on OS X, so I can do
>      other work while I test.
>
>      lztestmanager: Only turn of logging for swf9, otherwise `ant
>      runlzunit` will always fail!
>
>      build.xml: Default swf tests to swf8.
>
>Tests:
>      ant lztest, and runlzunit, amazon, test case from LPP-5762
>
>Files:
>M      WEB-INF/lps/lfc/core/LzNode.lzs
>M      build-tools/runlzunit.sh
>M      lps/components/lztest/lztestmanager.lzx
>M      lps/components/base/basetree.lzx
>M      build.xml
>
>Changeset: 
><http://svn.openlaszlo.org/openlaszlo/patches/20080411-ptw-r.tar>http://svn.openlaszlo.org/openlaszlo/patches/20080411-ptw-r.tar
-------------- next part --------------
An HTML attachment was scrubbed...
URL: http://www.openlaszlo.org/pipermail/laszlo-dev/attachments/20080411/6c1958a3/attachment-0001.html