[Laszlo-dev] For Review: Change 20080404-ptw-8 Summary:, Finish instance classes

[André Bargull]

In "LzReplicationManager#construct(..)":
> this.cloneAttrs = new LzInheritedHash(view._instanceAttrs);
Maybe this needs to be changed, because "_instanceAttrs" may be 
null/undefined?
> this.cloneAttrs = new LzInheritedHash(view._instanceAttrs || {});
I'll test that later.

> Confirmed fix to smokecheck.
>
> Don't know if this is tied to this change, but I'm getting errors in  
> lzpix, dhtml only:
>
> this._instanceAttrs has no properties
> [Break on this error]  
> this 
> .nodeType 
> =LzDataNode.DOCUMENT_NODE;this.queuerequests=false;this.oncanvas=$1...
> LFCdhtml.js (line 4873)
> this._instanceAttrs has no properties
> [Break on this error]  
> this 
> .nodeType 
> =LzDataNode.DOCUMENT_NODE;this.queuerequests=false;this.oncanvas=$1...
> LFCdhtml.js (line 4873)
>
> On Apr 4, 2008, at 6:44 PM, P T Withington wrote:
>
> >/ This fixes the double events in Amazon and smokecheck.
> />/
> />/ Change 20080404-ptw-8 by ptw at dueling-banjos.local <http://www.openlaszlo.org/mailman/listinfo/laszlo-dev> on 2008-04-04  
> />/ 18:39:11 EDT
> />/    in /Users/ptw/OpenLaszlo/ringding-clean
> />/    for http://svn.openlaszlo.org/openlaszlo/trunk
> />/
> />/ Summary: Finish instance classes
> />/
> />/ Bugs Fixed:
> />/ LPP-5625 'Implement instances with methods as singleton classes'
> />/
> />/ Technical Reviewer: hminsky (pending)
> />/ QA Reviewer: dda (pending)
> />/
> />/ Details:
> />/    Just compile the instance as a class without any arguments.  You
> />/    didn't really need to preserve _instanceAttrs after all.
> />/
> />/ Tests:
> />/    smokecheck, amazon
> />/
> />/ Files:
> />/ M      WEB-INF/lps/server/src/org/openlaszlo/compiler/NodeModel.java
> />/
> />/ Changeset: http://svn.openlaszlo.org/openlaszlo/patches/20080404-ptw-8.tar
> /
>
> --
>
> Don Anderson
> Java/C/C++, Berkeley DB, systems consultant
>
> voice: 617-547-7881
> email: dda at ddanderson.com <http://www.openlaszlo.org/mailman/listinfo/laszlo-dev>
> www: http://www.ddanderson.com