[Laszlo-dev] For Review: Change 20080404-dda-X Summary: Added lzc command line options for cache directory and output name, other minor command line cleanup.

[Donald Anderson]

Fixed that nit.  Thanks!

On Apr 5, 2008, at 10:27 AM, Philip Romanik wrote:

> Approved. The only nit I saw was the output of --help. The  
> description of script-cache-dir and media-cache-dir is the same.
>
>
> --script-cache-dir directory
>   Location of script cache directory (default <lps>/work/scache)
> --media-cache-dir directory
>   Location of script cache directory (default <lps>/work/cache/ 
> cmcache)
>
>
>> Phil,
>>
>> I neglected to get a QA review for this change set, and I'd feel  
>> better about it, even
>> if after the fact (since I'm guessing normal QA cycle won't run lzc).
>> I should have put you on to begin with.
>> Could you try this change to lzc command line options?
>> It's against pagan-deities.
>> It should work on Windows the same way.
>>
>> Thanks!
>>
>> - Don
>>
>> Begin forwarded message:
>>
>>
>> From: Donald Anderson <dda at ddanderson.com>
>> Date: April 4, 2008 2:43:17 PM EDT
>> To: ptw at laszlosystems.com
>> Cc: laszlo-dev at openlaszlo.org
>> Subject: For Review: Change 20080404-dda-X Summary: Added lzc  
>> command line options for cache directory and output name, other  
>> minor command line cleanup.
>>
>> Change 20080404-dda-X by dda at lester.local on 2008-04-04 14:22:26 EDT
>>    in /Users/dda/laszlo/src/svn/openlaszlo/branches/pagan-deities
>>    for http://svn.openlaszlo.org/openlaszlo/branches/pagan-deities
>>
>> Summary: Added lzc command line options for cache directory and  
>> output name, other minor command line cleanup.
>>
>> New Features: in lzc, new command line options --script-cache-dir,  
>> --media-cache-dir, --output (-o)
>>
>> Bugs Fixed: LPP-5571
>>
>> Technical Reviewer: ptw (pending)
>> QA Reviewer: (pending)
>> Doc Reviewer: (pending)
>>
>> Documentation:
>>
>> Release Notes:
>>
>> Details:
>>    compiler/Main.java:
>>      Added --script-cache-dir directory
>>      Added --media-cache-dir directory
>>      Added --output file (or -o file)
>>        only permitted with one input file
>>
>>      Delaying creating the caches until we know the directory names
>>      required some small rearrangement of code (for -mcache).
>>
>>      Print message if invalid arg for -mcache.
>>
>>      If no input files, issue message.
>>
>>      Protect against trailing options like "lzc --output"
>>      that would otherwise result in runtime error.
>>
>> Tests:
>>
>> Files:
>> M      WEB-INF/lps/server/src/org/openlaszlo/compiler/Main.java
>>
>> Changeset: http://svn.openlaszlo.org/openlaszlo/patches/20080404-dda-X.tar
>>
>>
>>
>> --
>>
>> Don Anderson
>> Java/C/C++, Berkeley DB, systems consultant
>>
>> voice: 617-547-7881
>> email: dda at ddanderson.com
>> www: http://www.ddanderson.com
>>
>>
>>
>>
>>
>> --
>>
>> Don Anderson
>> Java/C/C++, Berkeley DB, systems consultant
>>
>> voice: 617-547-7881
>> email: dda at ddanderson.com
>> www: http://www.ddanderson.com
>>
>>
>>
>>


--

Don Anderson
Java/C/C++, Berkeley DB, systems consultant

voice: 617-547-7881
email: dda at ddanderson.com
www: http://www.ddanderson.com




-------------- next part --------------
An HTML attachment was scrubbed...
URL: http://www.openlaszlo.org/pipermail/laszlo-dev/attachments/20080405/6a45e790/attachment.html