[Laszlo-dev] For Review: Change 20080401-Philip-2. Summary: Convert data classes to build in swf/dhtml/swf9

[Philip Romanik]

Hi André,

Thanks for the feedback. In my next set of 
changes I will modify the code so this check 
isn't needed, or is greatly simplified.

Thanks!

Phil


>Without doing a careful review, one note from me:
>In "LzDatapoiner#runXPath(..)", you need to test for:
> > if ( this.context && (this.context is LzDatapointer || this.context is
> > LzDataset || this.context is AnonDatasetGenerator)) {
> >         newc = this.context.getContext(); }
>But I guess, you should add a common interface 
>to LzDatapointer, LzDataset and AnonDatasetGenerator.
>
>
>
> > Change 20080401-Philip-2 by Philip at 
> Philip-DC 
> <<http://www.openlaszlo.org/mailman/listinfo/laszlo-dev>http://www.openlaszlo.org/mailman/listinfo/laszlo-dev> 
> on 2008-04-01 20:23:26 EDT
> >      in /cygdrive/f/laszlo/svn/src/svn/openlaszlo/trunk2
> >      for 
> <http://svn.openlaszlo.org/openlaszlo/trunk>http://svn.openlaszlo.org/openlaszlo/trunk
> >
> > Summary: Convert data classes to build in swf/dhtml/swf9
> >
> > New Features:
> >
> > Bugs Fixed:
> >
> > Technical Reviewer: ptw
> > QA Reviewer: (pending)
> > Doc Reviewer: (pending)
> >
> > Documentation:
> >
> > Release Notes:
> >
> > Details:
> > Converted lfc so data classes build in swf/dhtml/swf9. There is no
> > new functionality in this release. The data classes build on swf9 but
> > you will see a number of runtime errors until debugging is finished.
> >
> > The dummydata classes are no longer needed.
> >
> > Comments:
> >
> > kernel/swf/LzLoader.lzs - LzDataText and LzDataElement objects are
> > created that bypass initialization. I patched the file so it works,
> > but this needs to be fixed (LPP-5690).
> >
> > LzMiniNode - Figure out if more functionality is needed in this class
> > (like setAttribute).
> >
> > LzDataElement - Copied some debug routines for building swf9. These
> > will be removed when the entire lfc is running in swf9.
> >
> > LzReplicationManager, LzResizeReplicationManager - A few pieces of
> > code are commented out from swf9 builds until I figure out the right
> > thing to do.
> >
> >
> > Tests:
> > smoketest, and /lfc/data/alldata.lzx in swf/dhtml
> > amazon, lzpix, calendar in swf/dhtml. I can't (currently) run 'ant
> > lztest' in a native windows environment.
> >
> > I found one regression but I see it in a clean sandbox as well. lzpix
> > in swf shows the picture 'Tags' on top of each other.
> >
> >
> > Files:
> > M      WEB-INF/lps/lfc/kernel/swf/LzLoader.lzs
> > M      WEB-INF/lps/lfc/core/LzNode.lzs
> > M      WEB-INF/lps/lfc/core/dummyclasses.js
> > M      WEB-INF/lps/lfc/data/LzMiniNode.lzs
> > M      WEB-INF/lps/lfc/data/LzReplicationManager.lzs
> > M      WEB-INF/lps/lfc/data/LzDatapointer.lzs
> > M      WEB-INF/lps/lfc/data/LzDataNode.lzs
> > M      WEB-INF/lps/lfc/data/LzDataRequest.lzs
> > M      WEB-INF/lps/lfc/data/LzResizeReplicationManager.lzs
> > M      WEB-INF/lps/lfc/data/LzParsedPath.lzs
> > M      WEB-INF/lps/lfc/data/LzLazyReplicationManager.lzs
> > M      WEB-INF/lps/lfc/data/LzDataText.lzs
> > M      WEB-INF/lps/lfc/data/LzDataElement.lzs
> > M      WEB-INF/lps/lfc/data/LzHTTPDataProvider.lzs
> > M      WEB-INF/lps/lfc/data/LzDataset.lzs
> > M      WEB-INF/lps/lfc/data/LzDatapath.lzs
> > M      WEB-INF/lps/lfc/data/LzDatasource.lzs
> > M      WEB-INF/lps/lfc/data/Library.lzs
> > M      WEB-INF/lps/lfc/data/LzParam.lzs
> > M      WEB-INF/lps/lfc/data/LzDataAttrBind.lzs
> >
> > Changeset: 
> <http://svn.openlaszlo.org/openlaszlo/patches/20080401-Philip-2.tar>http://svn.openlaszlo.org/openlaszlo/patches/20080401-Philip-2.tar
>
-------------- next part --------------
An HTML attachment was scrubbed...
URL: http://www.openlaszlo.org/pipermail/laszlo-dev/attachments/20080402/b2a6e1b1/attachment.html