[Laszlo-dev] For Review: Change 20080401-ptw-A Summary: Compile instances with methods as classes

Henry Minsky henry.minsky at gmail.com
Tue Apr 1 14:18:46 PDT 2008


This looks good, I'm still reviewing it, but it gets a lot further now
running the checkbox app.


On Tue, Apr 1, 2008 at 4:25 PM, P T Withington <ptw at pobox.com> wrote:

> Change 20080401-ptw-A by ptw at dueling-banjos.local on 2008-04-01 16:15:19
> EDT
>    in /Users/ptw/OpenLaszlo/ringding-clean
>    for http://svn.openlaszlo.org/openlaszlo/trunk
>
> Summary: Compile instances with methods as classes
>
> Bugs Fixed:
> LPP-5625 'Implement instances with methods as singleton classes'
>
> Technical Reviewer: hqm (pending)
> QA Reviewer: dda (pending)
>
> Details:
>    LzNode, NodeModel: Move $classrootdepth computation to compile-time.
>
>    LzNode, LaszloCanvas, LzReplicationManager: Take care that
>    _instanceAttrs may be null
>
>    LzRuntime: Don't clobber global in swf9
>
>    ClassCompiler, ClassModel: Move emitClassDeclaration to ClassModel
>
>    NodeModel: Leave id as an attribute, declare named children as
>    attributes so they can be resolved.  Predicate for nodes that have
>    methods.  Compile nodes with methods as singleton classes.
>
>    basecomponent:  Make the optional argument optional
>
> Tests:
>    smokecheck, lztest, Henry's checkbox test compiles
>
> Files:
> M      WEB-INF/lps/lfc/core/LzNode.lzs
> M      WEB-INF/lps/lfc/views/LaszloCanvas.lzs
> M      WEB-INF/lps/lfc/data/LzReplicationManager.lzs
> M      WEB-INF/lps/lfc/compiler/LzRuntime.lzs
> M      WEB-INF/lps/server/src/org/openlaszlo/compiler/ClassCompiler.java
> M      WEB-INF/lps/server/src/org/openlaszlo/compiler/NodeModel.java
> M      WEB-INF/lps/server/src/org/openlaszlo/compiler/ClassModel.java
> M      lps/components/base/basecomponent.lzx
>
> Changeset: http://svn.openlaszlo.org/openlaszlo/patches/20080401-ptw-A.tar
>



-- 
Henry Minsky
Software Architect
hminsky at laszlosystems.com
-------------- next part --------------
An HTML attachment was scrubbed...
URL: http://www.openlaszlo.org/pipermail/laszlo-dev/attachments/20080401/33e54d03/attachment.html


More information about the Laszlo-dev mailing list