[Laszlo-dev] For Review: Change 20071025-ben-K Summary: Fix for LPP-4960, images are corrupted in reference and developer's guide
ben at laszlosystems.com
Mon Oct 29 15:42:45 PDT 2007
On Oct 29, 2007, at 3:27 PM, P T Withington wrote:
> 1) I wonder why you have to use such a complex pattern set to list
> the images, when the pattern to exclude them is simple (uses **).
It actually makes sense -- I don't want to include *any* images when
I'm excluding images, so the simple pattern is enough. When I do want
to grab images, I only want to grab *particular* images; I do not
want to grab images from, for example,
although I do want to grab
Rather than listing exactly which ones I want to exclude, I'm listing
exactly which ones I want to include, so that it's future-proofed; we
won't accidentally start grabbing some new images source directory.
> Otherwise approved.
> On 2007-10-25, at 21:01 EDT, Benjamin Shine wrote:
>> Change 20071025-ben-K by ben at slim.local on 2007-10-25 17:56:48 PDT
>> in /Users/ben/src/svn/openlaszlo/trunk
>> for http://svn.openlaszlo.org/openlaszlo/trunk
>> Summary: Fix for LPP-4960, images are corrupted in reference and
>> developer's guide
>> New Features:
>> Bugs Fixed: LPP-4960 Images not displaying or corrupted in
>> Developer Guide
>> Technical Reviewer: ptw (pending)
>> QA Reviewer: frisco (pending)
>> Doc Reviewer: frisco (pending)
>> When copying images from $LPS_HOME/docs into the build directories,
>> in preparation for tarring or gzipping, ant used to try to do
>> token substitution on images. Some of our images apparently had
>> the string VERSIONID id in them, when their bits were interpreted
>> as character data. This change copies the images into the build
>> directories without doing the token replacement.
>> Release Notes:
>> This was checked in to paperpie as r7013; I am hand-merging it to
>> Run a build, and deploy it. Go to the compiler chapter of the
>> guide. (For paperpie, this is at
>> compiler.html )
>> In section 1.1, there should be an image of the developer's
>> console. Before
>> this change, that image was corrupted.
>> More specifically,
>> should be a good image. Before this change, that image was corrupt.
>> M build.xml
>> Changeset: http://svn.openlaszlo.org/openlaszlo/patches/20071025-
More information about the Laszlo-dev