[Laszlo-dev] For Review: Change 20071019-jcrowley-N Summary: Various LzPix fixes

[Philip Romanik]

Approved!


>Ahhhhh, I see.  I didn't realize that the arrows would behave 
>entirely differently when a photo was selected.  I'll fix...
>
>If you're up for approving this fix, I can file a bug against the 
>prematurely disappearing spinning screen and the arrow behavior and 
>counter not working as expected when an image is selected.  (I 
>believe they're separate issues from what this fix addresses.)
>
>On Oct 24, 2007, at 3:38 PM, Philip Romanik wrote:
>
>
>I found a couple of nits.
>
>When you go to another flicker page (ie. another set of 100), the 
>spinning graphic in the window disappears prematurely.
>
>Select a photo and then move to the previous window. The images 
>displayed is wrong. For example, if the image range was 127-139 
>before, it becomes 101-113 after. Also, for a short period of time 
>the display says 101-101.
>
>If you perform a search that has a few dozen pictures, and select an 
>image, changing pages doesn't work very well.
>
>
>
>
>Change 20071019-jcrowley-N by 
><mailto:jcrowley at doctormanhattan.mshome.net>jcrowley at doctormanhattan.mshome.net 
>on 2007-10-19 04:46:51 EDT
>     in /Users/jcrowley/src/svn/openlaszlo/trunk-a
>     for 
> <http://svn.openlaszlo.org/openlaszlo/trunk>http://svn.openlaszlo.org/openlaszlo/trunk
>
>Summary: Various LzPix fixes
>
>New Features:
>
>Bugs Fixed: LPP-4877 - LZPix, SWF7 FireFox 2.0.0.7 WXP SP2: Scrolling
>             beyond 100 photos (or back from over 100) mashes counter and
>             counter only incremements by one
>             LPP-4876 - LZPix, SWF7 Safari 2.0.4 OSX 10.4.10: Searches
>             only returning 100 photos
>             LPP-4874 - LZPix, SWF7 Firefox 2.0.0.7 OSX 10.4.10: Scrolling
>             backwards through found set presents photos in expanding grouping
>             LPP-4873 - LZPix, SWF7 Firefox 2.0.0.7 OSX 10.4.10: Scrolling
>             quickly during photo download will result in empty photo pane.
>
>Technical Reviewer: max
>QA Reviewer: ben
>Doc Reviewer:
>
>Documentation:
>
>Release Notes:
>
>Details: It turns out, Flickr's data can only be loaded in pages
>             of up to 100.  So when there are more than 100 results,
>             it's broken up into separate XML pages that have to be
>             individually requested.  So I added in a bunch of stuff
>             to facilitate this, where if you get to the end of one
>             list, it will request the next list when you move to the
>             right.  This results in a rather insubstantial bit of
>             loading time while we switch between sheets.  I added a
>             text field that temporarily replaces the image counter
>             in the lower right-hand side that appears during this
>             loading time, to indicate that it's getting the next 100
>             or previous 100 (if you're going backward).
>
>             In doing so, I also made it so you can't scroll beyond
>             the 100 in each list, which fixes one of the other bugs.
>
>             Meanwhile, I noticed and fixed a few minor glitches while
>             I was in there (like if you search for a new term, the
>             search results come in starting at the image number
>             where you'd left off in the previous search), and
>             a couple other minor things (misplaced text, etc).
>
>Tests: Run modified LzPix versus unmodified:
>
>             Move beyond 100 images.  Note that new data is loaded
>             after you get to the end of the first set of 100, and
>             that you no longer move off into oblivion with a
>             broken counter.
>
>             Move backward from 100, and note that you move into the
>             previous data.  Note that images aren't grouped together
>             awkwardly as described in LPP-4874.
>
>             Move forward to about 150.  Search for something new,
>             either by using the search box or clicking on one of
>             the "favorites" pictures.  Note that the image count
>             resets instead of remaining where you were.
>
>Files:
>M      demos/lzpix/app.lzx
>M      demos/lzpix/classes/search.lzx
>M      demos/lzpix/classes/photo.lzx
>M      demos/lzpix/classes/pivotlayout.lzx
>M      demos/lzpix/classes/favorites.lzx
>M      demos/lzpix/views/tools.lzx
>
>Changeset: 
><http://svn.openlaszlo.org/openlaszlo/patches/20071019-jcrowley-N.tar>http://svn.openlaszlo.org/openlaszlo/patches/20071019-jcrowley-N.tar 
>
>
>
-------------- next part --------------
An HTML attachment was scrubbed...
URL: http://www.openlaszlo.org/pipermail/laszlo-dev/attachments/20071024/ce215013/attachment.html