[Laszlo-dev] For Review: Change 20071019-hqm-4 Summary: make tag compiler check for collisions of attribute names with properties of Object and Instance

Tue Oct 23 19:26:55 PDT 2007

Approved.

On Oct 23, 2007, at 10:40 AM, Henry Minsky wrote:

> Change 20071022-hqm-4 by hqm at IBM-2E06404CB67 on 2007-10-22 22:32:36  
> EDT
>     in /cygdrive/c/users/hqm/openlaszlo/trunk
>     for http://svn.openlaszlo.org/openlaszlo/trunk
>
> Summary:  make better LZX compiler warnings for colliding attribute  
> names
>
> New Features:
>
> Bugs Fixed: LPP-3910
>
> Technical Reviewer: ptw
> QA Reviewer: dda
> Doc Reviewer:
>
> Documentation:
>
> Release Notes:
>
> Details:
>
> Use AttributeSpec to store declared methods in addition to  
> attributes, so it's
> easier to detect attributes overriding methods and vice versa.
>
> Add or improve various warnings
>
>
>
> Tests:
>
> ant test
> ant lztest
> compile webtop mail app
> demos
>
> verify that the compiled javascript is same after this patch as  
> before on
> smokecheck and webtop app
>
>
> Files:
> A      test/compiler_errors/override-x-attribute.lzx
> A      test/compiler_errors/method-override.lzx
> A      test/compiler_errors/attribute-overrides-method.lzx
> M      WEB-INF/lps/schema/lfc.lzx
> M      WEB-INF/lps/server/src/org/openlaszlo/xml/internal/Schema.java
> M      WEB-INF/lps/server/src/org/openlaszlo/compiler/ 
> ClassCompiler.java
> M      WEB-INF/lps/server/src/org/openlaszlo/compiler/ 
> ViewSchema_Test.java
> M      WEB-INF/lps/server/src/org/openlaszlo/compiler/ViewSchema.java
> M      WEB-INF/lps/server/src/org/openlaszlo/compiler/NodeModel.java
> M      WEB-INF/lps/server/src/org/openlaszlo/compiler/Compiler.java
> M      WEB-INF/lps/server/src/org/openlaszlo/compiler/ 
> AttributeSpec.java
> M      WEB-INF/lps/server/src/org/openlaszlo/compiler/ClassModel.java
>
> Changeset: http://svn.openlaszlo.org/openlaszlo/patches/20071022- 
> hqm-4.tar
>
>
> On 10/23/07, Henry Minsky <henry.minsky at gmail.com> wrote:
> It's coming soon, I went back and added a few things, I'll post  
> later today...
>
>
>
>
> On 10/23/07, Donald Anderson < dda at ddanderson.com> wrote:
> Henry,
>
> Was there a repost of this I was supposed to review?
> I didn't see it and
>   http://svn.openlaszlo.org/openlaszlo/patches/20071019-hqm-4.tar
> appears not to have changed.
>
> - Don
>
> On Oct 19, 2007, at 3:35 PM, Henry Minsky wrote:
>
>> Oops, I forgot to put NodeModel.java in, which actually writes the
>> warning; I'll repost a new tar file...
>>
>>
>>
>> On 10/19/07, Donald Anderson < dda at ddanderson.com> wrote:
>> Henry, how do I get warnings to appear?
>> I tried the following test case:
>>
>> <canvas>
>>    <class name="texty" extends="text">
>>      <method name="call" args="val">
>>        var result = "hello " + val;
>>        // arbitrary javascript here.
>>        this.setText(result);
>>      </method>
>>      <method name="apply" args="val">
>>        var result = "hello " + val;
>>        // arbitrary javascript here.
>>        this.setText(result);
>>      </method>
>>      <method name="onmousedown" args="val">
>>        var result = "hello " + val;
>>        // arbitrary javascript here.
>>        this.setText(result);
>>      </method>
>>    </class>
>>    <simplelayout />
>>    <texty name="foo1" />
>>    <texty name="foo2" />
>>    <script>
>>      // the first case works
>>      foo1.call("world");
>>      foo2.call("galaxy");
>>      foo1.apply("whirled");
>>      foo2.onmousedown("xyz");
>>      foo2.apply("gal-ax-sea");
>>    </script>
>> </canvas>
>>
>> and was able to create/call method names with 'call' and 'apply'  
>> without
>> a problem.  What am I missing?
>>
>> - Don
>>
>> On Oct 19, 2007, at 1:23 AM, Henry Minsky wrote:
>>
>> > Change 20071019-hqm-4 by hqm at IBM-2E06404CB67 on 2007-10-19 01:05:50
>> > EDT
>> >     in /cygdrive/c/users/hqm/openlaszlo/trunk
>> >     for http://svn.openlaszlo.org/openlaszlo/trunk
>> >
>> > Summary: make tag compiler check for collisions of attribute names
>> > with properties of Object and Instance
>> >
>> > New Features:
>> >
>> > Bugs Fixed: LPP-4939
>> >
>> > Technical Reviewer: ptw
>> > QA Reviewer: dda
>> > Doc Reviewer:
>> >
>> > Documentation:
>> >
>> > Release Notes:
>> >
>> > Details:
>> >
>> > Make "Object" the base class for the LFC ViewSchema.
>> > Declare "Instance" in lfc.lzx, and declare attributes on it.
>> > (technically a couple of them belong to 'Object', not Instance:   
>> call,
>> > apply) but it doesn't really
>> > matter.
>> >
>> >
>> > Tests:
>> >
>> > smokecheck
>> > compile webtop lzmail and compare script output previous to this
>> > change
>> >
>> > Files:
>> > M      WEB-INF/lps/schema/lfc.lzx
>> > M      WEB-INF/lps/server/src/org/openlaszlo/compiler/ 
>> ViewSchema.java
>> >
>> > Changeset: http://svn.openlaszlo.org/openlaszlo/patches/20071019-
>> > hqm-4.tar
>> >
>> >
>> > --
>> > Henry Minsky
>> > Software Architect
>> > hminsky at laszlosystems.com
>>
>>
>> --
>>
>> Don Anderson
>> Java/C/C++, Berkeley DB, systems consultant
>>
>> Voice:  617-547-7881
>> Email:   dda at ddanderson.com
>> WWW:    http://www.ddanderson.com
>>
>>
>>
>>
>> -- 
>> Henry Minsky
>> Software Architect
>> hminsky at laszlosystems.com
>>
>
>
> --
>
> Don Anderson
> Java/C/C++, Berkeley DB, systems consultant
>
> Voice:  617-547-7881
> Email:  dda at ddanderson.com
> WWW:    http://www.ddanderson.com
>
>
>
>
> --
>
> Henry Minsky
> Software Architect
> hminsky at laszlosystems.com
>
>
>
>
> -- 
> Henry Minsky
> Software Architect
> hminsky at laszlosystems.com
>

--

Don Anderson
Java/C/C++, Berkeley DB, systems consultant

Voice:  617-547-7881
Email:  dda at ddanderson.com
WWW:    http://www.ddanderson.com

-------------- next part --------------
An HTML attachment was scrubbed...
URL: http://www.openlaszlo.org/pipermail/laszlo-dev/attachments/20071024/e117ff94/attachment.html