[Laszlo-dev] For Review: Change 20071102-hqm-0 Summary: don't throw error when selectChild() called on text node

[P T Withington]

Ok.  I didn't realize you were copying from the Firebug console.  I  
think if you dig, you will see that the right-hand line number (from  
Firebug) is where the error is reported, and the left-hand line number  
(from our debugger) is where the error occurred.  You won't see the  
Firebug number in our debug window.  So, really the only thing is that  
the debugger could abbreviate the file name...

On 2007-11-02, at 14:02 EDT, Philip Romanik wrote:

> I pasted part of two lines. I'm attaching a screen shot of the  
> firebug output. I'm not sure why two different line numbers are  
> reported.
>
>
>
>> That error message looks crappy.  Why is it reporting the full url  
>> (normally it abbreviates relative to the app root).  Why does the  
>> line number in the error disagree with the line number in the  
>> message?  Is either one of them right?  Is this a native browser  
>> error that is being caught and reported?  Maybe file a bug if there  
>> is a small test case?
>>
>> On 2007-11-02, at 12:44 EDT, Philip Romanik wrote:
>>
>> > Approved.
>> >
>> > The test app generates an error when LzDatapointer.getNodeText() is
>> > called.
>> >
>> > ERROR
>> > @http://localhost:8080/trunk/lps/includes/lfc/LFCdhtml-debug.js#14476
>> > : this.p.__LZgetText is not a functionLFCdhtml-debug.js (line 1463)
>> > this.p.__LZgetText is not a function []
>> >
>> >
>> >
>> >
>> >> Change 20071102-hqm-0 by hqm at IBM-2E06404CB67 on 2007-11-02  
>> 11:53:42
>> >> EDT
>> >>    in /cygdrive/c/users/hqm/openlaszlo/trunk/WEB-INF/lps/lfc
>> >>    for
>> >> <<http://svn.openlaszlo.org/openlaszlo/trunk/WEB-INF/lps/lfc>http://svn.openlaszlo.org/openlaszlo/trunk/WEB-INF/lps/lfc 
>> >http://sv
>> >> n.openlaszlo.org/openlaszlo/trunk/WEB-INF/lps/lfc
>> >>
>> >> Summary: don't throw error when selectChild() called on text node
>> >>
>> >> New Features:
>> >>
>> >> Bugs Fixed: LPP-4493
>> >>
>> >> Technical Reviewer: pbr
>> >> QA Reviewer: andre
>> >> Doc Reviewer:
>> >>
>> >> Documentation:
>> >>
>> >> Release Notes:
>> >>
>> >> Details:
>> >>
>> >> Check that functions exists before calling selector function on a
>> >> node
>> >>
>> >>
>> >>
>> >>
>> >> Tests:
>> >>
>> >> see test case in bug report.
>> >> Run in DHTML, click button, see that no Firebug error occurs
>> >>
>> >>
>> >>
>> >> Files:
>> >> M      data/LzDatapointer.lzs
>> >>
>> >>
>> >> Changeset:
>> >> <http://svn.openlaszlo.org/openlaszlo/patches/20071102-hqm-0.tar
>> >> ><http://svn.openlaszlo.org/openlaszlo/patches/20071102-hqm-0.tar   
>> >http://svn.openlaszlo.org/openlaszlo/patches/20071102-hqm-0.tar
>> >>
>> >>
>> >> --
>> >> Henry Minsky
>> >> Software Architect
>> >> <<mailto:hminsky at laszlosystems.com>mailto:hminsky at laszlosystems.com 
>> ><mailto:hminsky at laszlosystems.com>hminsky at laszlosystems.com
>>
> <output1.gif>