[Laszlo-dev] For Review: Change 20070628-Philip-0. Summary: Corrected. Fix lztest-lzanimatorgroup.lzx, Fix lztest-lzanimator.lzx

[Benjamin Shine]

Approved.

On Jun 28, 2007, at 4:04 PM, Philip Romanik wrote:

> Change 20070628-Philip-0 by Philip at Philip-DC on 2007-06-28 18:51:22  
> EST
>     in /cygdrive/f/laszlo/svn/src/svn/openlaszlo/branches/legals
>     for http://svn.openlaszlo.org/openlaszlo/branches/legals
>
> Summary: Corrected. Fix lztest-lzanimatorgroup.lzx, Fix lztest- 
> lzanimator.lzx
>
> New Features:
>
> Bugs Fixed: LPP-3994
>
> Technical Reviewer: ben
> QA Reviewer: (pending)
> Doc Reviewer: (pending)
>
> Documentation:
>
> Release Notes:
>
> Details:
> When I checked in the change to LPP-3994 I forgot to check in a  
> change to the un it test file. This change is safe to merge to the  
> 4.0 branch.
>
> I also modified lztest-animator.lzx and lztest-animatorgroup.lzx to  
> print warnings rather than generating errors in three cases. The  
> first case is round-off. This is a known issue where the expected  
> value differs from the actual value by a  small delta (on the order  
> of 1e-14). I added a local method to show a warning message rather  
> than generate an error. The second change is to show a warning  
> instead of an error when elapsed time tests fail. The elapsed time  
> can fail. It often passes the first time it is run and then fail on  
> subsequent runs. The third case is when known jira bugs are  
> encountered.
>
> Both files can be merged to the 4.0 branch.
>
> Tests:
> lztest-animator.lzx
> lztest-animatorgroup.lzx
>
> Files:
> M      test/lztest/lztest-animator.lzx
> M      test/lztest/lztest-animatorgroup.lzx
>
> Changeset: http://svn.openlaszlo.org/openlaszlo/patches/20070628- 
> Philip-0.tar
>
>