[Laszlo-dev] potential merges from legals to 4.0.3: pbr

Benjamin Shine ben at laszlosystems.com
Fri Jun 22 16:19:50 PDT 2007 

Here is a list of Phil's fixes to legals that could potentially go  
into 4.0.3. Phil, please review this list and respond back with which  
revisions you *do* want merged, and risk vs. reward for each one.

r5101 | pbr | 2007-05-18 09:48:34 -0700 (Fri, 18 May 2007) | 32 lines
Changed paths:
    M /openlaszlo/branches/legals/lps/components/base/basetree.lzx

Change 20070517-Philip-6 by Philip at Philip-DC on 2007-05-17 13:11:53 EST
    in /cygdrive/f/laszlo/svn/src/svn/openlaszlo/branches/legals

Summary: Client hangs when destroying deeply nested tree (in swf)

New Features:

Bugs Fixed: LPP-3921

Technical Reviewer: jcrowley
QA Reviewer: (pending)
Doc Reviewer: (pending)

Documentation:

Release Notes:

Details:
Added basetree.destroy() to close the tree and destroy the children  
elements bef
ore anything else. This reduces the stack depth in swf and the  
problem is no lon
ger seen. This was never an issue with dhtml.

Tests:
Run the attached example in the comments. The original example  
doesn't run prope
rly in legals. Other tree examples continue to work just fine. If you  
run tree_e
xample.lzx, you'll see some display issues that are caused by another  
bug (LPP-3
959).

Files:
M      lps/components/base/basetree.lzx
Changeset: http://svn.openlaszlo.org/openlaszlo/patches/20070517- 
Philip-6.tar



------------------------------------------------------------------------
r5199 | pbr | 2007-05-24 06:02:38 -0700 (Thu, 24 May 2007) | 35 lines
Changed paths:
    M /openlaszlo/branches/legals/lps/components/base/basewindow.lzx

Change 20070523-Philip-6 by Philip at Philip-DC on 2007-05-23 10:29:23 EST
    in /cygdrive/f/laszlo/svn/src/svn/openlaszlo/branches/legals
    for http://svn.openlaszlo.org/openlaszlo/branches/legals

Summary: Calls to 'new window()' now work in dhtml

New Features:

Bugs Fixed: LPP-3923

Technical Reviewer: jcrowley
QA Reviewer: (pending)
Doc Reviewer: (pending)

Documentation:

Release Notes:

Details:
The window component requires a valid parent object. Calling
super.construct() makes sure that 'this.parent' is valid. The other
change is to use 'this.parent'
instead of what was passed to construct(). Calls to 'new window()' in  
dhtml now
work.

Tests:
Run test in LPP-3923 in swf and dhtml
http://localhost:8080/legals/examples/components/window_example.lzx in
dhtml and swf

Files:
M      lps/components/base/basewindow.lzx

Changeset: http://svn.openlaszlo.org/openlaszlo/patches/20070523- 
Philip-6.tar


------------------------------------------------------------------------
r5228 | pbr | 2007-05-25 15:05:29 -0700 (Fri, 25 May 2007) | 44 lines
Changed paths:
    M /openlaszlo/branches/legals/WEB-INF/lps/lfc/controllers/ 
LzAnimatorGroup.lzs

Summary:  Fix: this.actAnim has no properties, this.actAnim[$2].stop()


New Features:

Bugs Fixed: LPP-3994

Technical Reviewer: max
QA Reviewer: (pending)
Doc Reviewer: (pending)

Documentation:

Release Notes:

Details:
In LzAnimatorGroup, it is possible that the internal variable actAnim  
can be nul
l and this condition was not checked in stop().

I also found an off-by-one type error in two places. This line of code,

  var animend = this.process == "simultaneous" ? this.actAnim.length  
-1 : 0;

is wrong if the animation is "sequential" and there are no animations  
(ie. this.
actAnim.length = 0). I re-wrote to make it clearer and to handle this  
case.


Tests:
blabla app runs in dhtml. See jira report. I added a comment to the  
parent bug (
LPP-3964) on how I debugged the app.

/test/smoke/smokecheck.lzx

/test/lztest/lztest-animator.lzx, /test/lztest/lztest- 
animatorgroup.lzx match in
  swf and dhtml.

lzpix


Files:
M      WEB-INF/lps/lfc/controllers/LzAnimatorGroup.lzs

Changeset: http://svn.openlaszlo.org/openlaszlo/patches/20070525- 
Philip-4.tar



------------------------------------------------------------------------
r5253 | pbr | 2007-05-30 05:54:20 -0700 (Wed, 30 May 2007) | 31 lines
Changed paths:
    M /openlaszlo/branches/legals/demos/amazon/address.lzx

Change 20070525-Philip-8 by Philip at Philip-DC on 2007-05-25 12:09:54 EST
    in /cygdrive/f/laszlo/svn/src/svn/openlaszlo/branches/legals
    for http://svn.openlaszlo.org/openlaszlo/branches/legals

Summary: make Amazon demo shipping address fit in window

New Features:

Bugs Fixed: LPP-3743

Technical Reviewer: jcrowley
QA Reviewer: (pending)
Doc Reviewer: (pending)

Documentation:

Release Notes:

Details:
I removed some white space so the form fits within the region. The  
layout looks
fine.


Tests:
amazon app in dhtml/swf in IE6/IE7/FF1.5/FF2.0/Opera9.1

Files:
M      demos/amazon/address.lzx

Changeset: http://svn.openlaszlo.org/openlaszlo/patches/20070525- 
Philip-8.tar

------------------------------------------------------------------------
r5254 | pbr | 2007-05-30 05:57:41 -0700 (Wed, 30 May 2007) | 30 lines
Changed paths:
    M /openlaszlo/branches/legals/index.jsp

Change 20070525-Philip-a by Philip at Philip-DC on 2007-05-25 19:52:37 EST
    in /cygdrive/f/laszlo/svn/src/svn/openlaszlo/branches/legals
    for http://svn.openlaszlo.org/openlaszlo/branches/legals

Summary: Fixed link in internal index to weather app

New Features:

Bugs Fixed: LPP-4049

Technical Reviewer: jcrowley
QA Reviewer: (pending)
Doc Reviewer: (pending)

Documentation:

Release Notes:

Details:
The link to the dhtml version of the weather app was wrong.


Tests:
/index.jsp and click on Demos->calendar->dhtml link

Files:
M      index.jsp

Changeset: http://svn.openlaszlo.org/openlaszlo/patches/20070525- 
Philip-a.tar


------------------------------------------------------------------------
r5298 | pbr | 2007-06-02 06:43:29 -0700 (Sat, 02 Jun 2007) | 45 lines
Changed paths:
    M /openlaszlo/branches/legals/WEB-INF/lps/lfc/services/LzTrack.lzs

Change 20070529-Philip-6 by Philip at Philip-DC on 2007-05-29 14:15:49 EST
    in /cygdrive/f/laszlo/svn/src/svn/openlaszlo/branches/legals
    for http://svn.openlaszlo.org/openlaszlo/branches/legals

Summary: Ported LzTrack.lzs to new class system

New Features:

Bugs Fixed: LPP-3986

Technical Reviewer: ptw
QA Reviewer: (pending)
Doc Reviewer: (pending)

Documentation:

Release Notes:

Details:
Ported LzTrack.lzx to the new class system. LzTrack is a singleton  
class but is
written more like an ordinary class. To minimize the changes I made  
(and to make
  it 100% compatible with the old version), the class name is  
LzTrackClass. At th
e bottom of the file is:

    /** The single instance of this class
      * @access private
      */
    var LzTrack = new LzTrackClass;



Tests:
lzpix in swf and dhtml. The best test in this app is to drag an image  
into the c
lip region. When I first ported LzTrack the image disappeared when I  
released th
e mouse.

Run these in swf and dhtml:
http://localhost:8080/legals/test/lfc/lztrack/trackgroups.lzx
http://localhost:8080/legals/test/lfc/lztrack/trackgroup.lzx

Files:
M      WEB-INF/lps/lfc/services/LzTrack.lzs

Changeset: http://svn.openlaszlo.org/openlaszlo/patches/20070529- 
Philip-6.tar


------------------------------------------------------------------------
r5426 | pbr | 2007-06-15 07:32:33 -0700 (Fri, 15 Jun 2007) | 44 lines
Changed paths:
    M /openlaszlo/branches/legals/WEB-INF/lps/lfc/data/LzDatapointer.lzs
    M /openlaszlo/branches/legals/test/lfc/data/datapointer.lzx

Change 20070607-Philip-0 by Philip at Philip-DC on 2007-06-07 18:03:10 EST
    in /cygdrive/f/laszlo/svn/src/svn/openlaszlo/branches/legals
    for http://svn.openlaszlo.org/openlaszlo/branches/legals

Summary: Parse datapaths with '.'

New Features:

Bugs Fixed: LPP-3556

Technical Reviewer: hqm
QA Reviewer: (pending)
Doc Reviewer: (pending)

Documentation:

Release Notes:

Details:
It turns out that data attributes could not have a '.' in the name,
although this is valid XML. LzDatapointer.__LZprocessOperator() was
using split(".") to separate the operator ('attributes' in this case)
and data. If the operator is 'attributes', the code now uses substr()
to retain the entire line. For other operators, split() is still used.

I modified /test/data/alldata.lzx (see datapointer.lzx) to verify that
attributes can now be read properly. The dataset is:
    <dataset name="syntax">
        <data a="avalue" b="bvalue" a.b="a.bvalue"/>
    </dataset>


Tests:
Test case in LPP-3556
/test/lfc/data/alldata.lzx (swf, dhtml)
/test/smoke/smokecheck.lzx (swf, dhtml)
lzpix

Files:
M      test/lfc/data/datapointer.lzx
M      WEB-INF/lps/lfc/data/LzDatapointer.lzs

Changeset: http://svn.openlaszlo.org/openlaszlo/patches/20070607- 
Philip-0.tar

More information about the Laszlo-dev mailing list