[Laszlo-dev] For Review: Change 20070621-Philip-4. Summary: Fix doRequest() when called on built-in dataset

[Philip Romanik]

Change 20070621-Philip-4 by Philip at Philip-DC on 2007-06-21 14:52:21 EST
     in /cygdrive/f/laszlo/svn/src/svn/openlaszlo/branches/legals
     for http://svn.openlaszlo.org/openlaszlo/branches/legals

Summary: Fix doRequest() when called on built-in dataset

New Features:

Bugs Fixed: LPP-3951

Technical Reviewer: hqm
QA Reviewer: (pending)
Doc Reviewer: (pending)

Documentation:

Release Notes:

Details:
In the test app, a dataset is specified as,

   <dataset name="mydata" src="testbasket.xml">

The data is compiled into the app by the data compiler. In this mode, there 
is no src attribute in LzDataset (or LzHTTPDatasource). If 
LzDataset.doRequest() is called, the code assumes that the src attribute is 
valid. If you run it in dhtml you'll see the error. In swf you see the tree 
data disappears.

The best solution is to check the src value in LzHTTPDatasource.doRequest 
and silently return if this value is null.



Tests:
Run the test case in LPP-3951. If you click the LoadData button, the tree 
doesn't disappear anymore. The compilation warning generated by the app is 
covered under LPP-3952.

/test/smoke/smokecheck.lzx (swf and dhtml) /test/lfc/data/alldata.lzx (swf 
and dhtml)

Files:
M      WEB-INF/lps/lfc/data/LzHTTPDatasource.lzs

Changeset: http://svn.openlaszlo.org/openlaszlo/patches/20070621-Philip-4.tar