[Laszlo-dev] for review, change to lztext/sprite to make widths match in sprite and LFC (swf)

[Max Carlson]

lztest-textheight.lzx passes with and without your change in swf.  In 
DHTML, I saw these errors without your patch:
DEBUG: Source warnings enabledWARNING: testing:0: Test source warning
ERROR: In suite Text Size Test Suite, test 1, failed assertion: FAIL: 
text12 heightEquals expected 277, got 225
ERROR: In suite Text Size Test Suite, test 1, failed assertion: FAIL: 
text12 text.heightEquals expected 277, got 225
ERROR: In suite Text Size Test Suite, test 2, failed assertion: FAIL: 
text9 widthEquals expected 88, got 80
ERROR: In suite Text Size Test Suite, test 2, failed assertion: FAIL: 
text9 widthEquals expected 88, got 80
ERROR: In suite Text Size Test Suite, test 2, failed assertion: FAIL: 
text10 widthEquals expected 88, got 80
ERROR: In suite Text Size Test Suite, test 2, failed assertion: FAIL: 
text10 widthEquals expected 88, got 80
ERROR: Failed 1 suites, Text Size Test Suite

And these with your patch:
ERROR: In suite Text Size Test Suite, test 1, failed assertion: FAIL: 
text12 heightEquals expected 277, got 225
ERROR: In suite Text Size Test Suite, test 1, failed assertion: FAIL: 
text12 text.heightEquals expected 277, got 225
ERROR: In suite Text Size Test Suite, test 2, failed assertion: FAIL: 
text10 widthEquals expected 88, got 80
ERROR: In suite Text Size Test Suite, test 2, failed assertion: FAIL: 
text10 widthEquals expected 88, got 80
ERROR: In suite Text Size Test Suite, test 2, failed assertion: FAIL: 
inputtext5 widthEquals expected 17, got 1235
ERROR: In suite Text Size Test Suite, test 2, failed assertion: FAIL: 
inputtext5.widthEquals expected 17, got 1235
ERROR: Failed 1 suites, Text Size Test Suite


I filtered out the warnings that were common, and it looks like with 
your change this error goes away:
DEBUG: Source warnings enabledWARNING: testing:0: Test source warning
ERROR: In suite Text Size Test Suite, test 2, failed assertion: FAIL: 
text9 widthEquals expected 88, got 80
ERROR: In suite Text Size Test Suite, test 2, failed assertion: FAIL: 
text9 widthEquals expected 88, got 80
ERROR: Failed 1 suites, Text Size Test Suite

And this one shows up:
ERROR: In suite Text Size Test Suite, test 2, failed assertion: FAIL: 
inputtext5 widthEquals expected 17, got 1235
ERROR: In suite Text Size Test Suite, test 2, failed assertion: FAIL: 
inputtext5.widthEquals expected 17, got 1235
ERROR: Failed 1 suites, Text Size Test Suite

Also, did you mean to include lztest-lpp-2958.lzx?  It now passes in 
DHTML and SWF.

There was one other nit - I'd prefer you use a private attribute instead 
of the getDefaultWidth() method call to get the default width.  In 
either case, the method or property should be prefixed with __ to 
designate it as 'private.'

Other than the inputtext5 issue, it looks good!

Henry Minsky wrote:
> Try this, it has an update to the textheight test.
> 
> note, there are two failures in the textheight
> 
> ERROR: In suite Text Size Test Suite, test 1, failed assertion: FAIL:
> inputtext5 heightEquals expected 52, got 54
> ERROR: In suite Text Size Test Suite, test 1, failed assertion: FAIL:
> inputtext5.heightEquals expected 52, got 54
> ERROR: Failed 1 suites, Text Size Test Suite
> 
> 
> But those happen in a clean sandbox for me before I applied these text
> changes
> 
> Change 20070611-hqm-6 by hqm at IBM-2E06404CB67 on 2007-06-11 19:43:45 EDT
>    in /cygdrive/c/users/hqm/openlaszlo/legals3
>    for http://svn.openlaszlo.org/openlaszlo/branches/legals
> 
> Summary: make sure swf sprite text-width matches LzView text-width
> 
> New Features:
> 
> Bugs Fixed: LPP-2958
> 
> Technical Reviewer: max (pending)
> QA Reviewer: (pending)
> Doc Reviewer: (pending)
> 
> Documentation:
> 
> Release Notes:
> 
> Details:
> 
> swf kernel textsprite was setting it's width in some cases without syncing
> up it's
> LzView owner.
> 
> + I removed the default 100 width on LzText, but left it for LzInputText.
> 
> 
> 
> Files:
> M      test/lztest/lztest-textheight.lzx
> M      WEB-INF/lps/lfc/kernel/swf/LzTextSprite.as
> M      WEB-INF/lps/lfc/views/LzInputText.lzs
> M      WEB-INF/lps/lfc/views/LzText.lzs
> 
> 
> Changeset: http://svn.openlaszlo.org/openlaszlo/patches/20070611-hqm-6.tar
> 
> 
> On 6/11/07, Max Carlson <max at openlaszlo.org> wrote:
>>
>> I reviewed the most recent version at
>> http://svn.openlaszlo.org/openlaszlo/patches/20070530-hqm-0.tar and
>>
>> http://localhost:8080/legals-clean/test/lztest/lztest-lpp-2958.lzx?debug=true&lzr=dhtml 
>>
>> still fails for me.  It passes under swf.  Do you get the same results?
>>
>> Also, this change causes
>>
>> http://localhost:8080/legals-clean/test/lztest/lztest-textheight.lzx?lzr=dhtml&debug=true 
>>
>>   to fail in swf and dhtml - but it's consistent now!
>>
>> -Max
>>
>> Henry Minsky wrote:
>> > Change 20070530-hqm-0 by hqm at IBM-2E06404CB67 on 2007-05-30 09:23:10 EDT
>> >    in /cygdrive/c/users/hqm/openlaszlo/legals3
>> >    for http://svn.openlaszlo.org/openlaszlo/branches/legals
>> >
>> > Summary: make sure swf sprite text-width matches LzView text-width
>> >
>> > New Features:
>> >
>> > Bugs Fixed: LPP-2958
>> >
>> > Technical Reviewer: max (pending)
>> > QA Reviewer: (pending)
>> > Doc Reviewer: (pending)
>> >
>> > Documentation:
>> >
>> > Release Notes:
>> >
>> > Details:
>> >
>> > swf kernel textsprite was setting it's width in some cases without
>> syncing
>> > up it's
>> > LzView owner.
>> >
>> > + I removed the default 100 width on LzText, but left it for
>> LzInputText.
>> >
>> >
>> >
>> >
>> >
>> > Tests:
>> >
>> > test/lztest/lztest-lpp-2958.lzx
>> >
>> > Files:
>> > M      WEB-INF/lps/lfc/kernel/swf/LzTextSprite.as
>> > M      WEB-INF/lps/lfc/views/LzInputText.lzs
>> > M      WEB-INF/lps/lfc/views/LzText.lzs
>> > A      test/lztest/lztest-lpp-2958.lzx
>> >
>> >
>> >
>> >
>>
>> -- 
>> Regards,
>> Max Carlson
>> OpenLaszlo.org
>>
> 
> 
> 

-- 
Regards,
Max Carlson
OpenLaszlo.org