[Laszlo-dev] for review, change to lztext/sprite to make widths match in sprite and LFC (swf)

[Henry Minsky]

Try this, it has an update to the textheight test.

note, there are two failures in the textheight

ERROR: In suite Text Size Test Suite, test 1, failed assertion: FAIL:
inputtext5 heightEquals expected 52, got 54
ERROR: In suite Text Size Test Suite, test 1, failed assertion: FAIL:
inputtext5.heightEquals expected 52, got 54
ERROR: Failed 1 suites, Text Size Test Suite


But those happen in a clean sandbox for me before I applied these text
changes

Change 20070611-hqm-6 by hqm at IBM-2E06404CB67 on 2007-06-11 19:43:45 EDT
    in /cygdrive/c/users/hqm/openlaszlo/legals3
    for http://svn.openlaszlo.org/openlaszlo/branches/legals

Summary: make sure swf sprite text-width matches LzView text-width

New Features:

Bugs Fixed: LPP-2958

Technical Reviewer: max (pending)
QA Reviewer: (pending)
Doc Reviewer: (pending)

Documentation:

Release Notes:

Details:

swf kernel textsprite was setting it's width in some cases without syncing
up it's
LzView owner.

+ I removed the default 100 width on LzText, but left it for LzInputText.



Files:
M      test/lztest/lztest-textheight.lzx
M      WEB-INF/lps/lfc/kernel/swf/LzTextSprite.as
M      WEB-INF/lps/lfc/views/LzInputText.lzs
M      WEB-INF/lps/lfc/views/LzText.lzs


Changeset: http://svn.openlaszlo.org/openlaszlo/patches/20070611-hqm-6.tar


On 6/11/07, Max Carlson <max at openlaszlo.org> wrote:
>
> I reviewed the most recent version at
> http://svn.openlaszlo.org/openlaszlo/patches/20070530-hqm-0.tar and
>
> http://localhost:8080/legals-clean/test/lztest/lztest-lpp-2958.lzx?debug=true&lzr=dhtml
> still fails for me.  It passes under swf.  Do you get the same results?
>
> Also, this change causes
>
> http://localhost:8080/legals-clean/test/lztest/lztest-textheight.lzx?lzr=dhtml&debug=true
>   to fail in swf and dhtml - but it's consistent now!
>
> -Max
>
> Henry Minsky wrote:
> > Change 20070530-hqm-0 by hqm at IBM-2E06404CB67 on 2007-05-30 09:23:10 EDT
> >    in /cygdrive/c/users/hqm/openlaszlo/legals3
> >    for http://svn.openlaszlo.org/openlaszlo/branches/legals
> >
> > Summary: make sure swf sprite text-width matches LzView text-width
> >
> > New Features:
> >
> > Bugs Fixed: LPP-2958
> >
> > Technical Reviewer: max (pending)
> > QA Reviewer: (pending)
> > Doc Reviewer: (pending)
> >
> > Documentation:
> >
> > Release Notes:
> >
> > Details:
> >
> > swf kernel textsprite was setting it's width in some cases without
> syncing
> > up it's
> > LzView owner.
> >
> > + I removed the default 100 width on LzText, but left it for
> LzInputText.
> >
> >
> >
> >
> >
> > Tests:
> >
> > test/lztest/lztest-lpp-2958.lzx
> >
> > Files:
> > M      WEB-INF/lps/lfc/kernel/swf/LzTextSprite.as
> > M      WEB-INF/lps/lfc/views/LzInputText.lzs
> > M      WEB-INF/lps/lfc/views/LzText.lzs
> > A      test/lztest/lztest-lpp-2958.lzx
> >
> >
> >
> >
>
> --
> Regards,
> Max Carlson
> OpenLaszlo.org
>



-- 
Henry Minsky
Software Architect
hminsky at laszlosystems.com
-------------- next part --------------
An HTML attachment was scrubbed...
URL: http://www.openlaszlo.org/pipermail/laszlo-dev/attachments/20070611/eb7eb190/attachment.html