[Laszlo-dev] For Review: Change 20070604-ben-a Summary: Add file upload (swf8 only)

[Philip Romanik]

Approved, but I recommend 3 changes.

1. The documentation in fileupload.lzx should mention an additional step 
for Windows users. The file storage path in upload.jsp.txt must be changed 
on Windows (and potentially other platforms).

2. In two places in multiplefileupload.lzx is:

     content.subviews[i].progressBar.destroy();
     content.subviews[i].remove.destroy();
     content.subviews[i].txtFile.destroy();
     content.subviews[i].browse.destroy();
     content.subviews[i].myFileUpload.destroy();
     content.subviews[i].destroy();

Why can't this simply be,

     content.subviews[i].destroy();


3. In test-multiplefileupload.lzx, there is a typo-o,

     <button onclick="mul.setNumFields(1)" text="Set number of fields to 2"/>



>Change 20070604-ben-a by ben at cooper.local on 2007-06-04 15:56:07 PDT
>      in /Users/ben/src/svn/openlaszlo/branches/legals
>      for http://svn.openlaszlo.org/openlaszlo/branches/legals
>
>Summary: Add file upload (swf8 only)
>
>New Features: Now you can upload files, when paired with a working
>servlet
>
>Bugs Fixed: LPP-878 Add support for file upload
>
>Technical Reviewer: pbr (pending)
>QA Reviewer: frisco (pending)
>Doc Reviewer: (pending)
>
>Documentation:
>This contribution from yfang provides flash8 file upload capability when 
>paired with a working servlet. An example servlet is included with the two 
>examples, but it is shipped with a .jsp.txt extension, so we don't open a 
>giant hole for anyone to upload anything onto any OL server.
>
>Release Notes:
>The file upload component will ONLY work with lzr=swf8, because it uses 
>the swf8 file upload support. This is not expected to work out of the box! 
>There are TWO steps
>which must be done
>to make it work. One, rename upload.jsp.txt to upload.jsp. Two, get
>cos.jar from
>servlets.com, and install it in tomcat.
>
>Details:
>
>Tests: http://localhost:8080/legals/lps/components/incubator/uploader/
>example/test-fileupload.lzx?lzr=swf8
>http://localhost:8080/legals/lps/components/incubator/uploader/
>example/test-multiplefileupload.lzx?lzr=swf8
>(Note that if you run with another runtime, there is just a text
>message saying that it requires swf8.)
>
>http://localhost:8080/legals/docs/reference/lz.fileupload.html
>http://localhost:8080/legals/docs/reference/lz.multiplefileupload.html
>http://localhost:8080/legals/docs/reference/lz.fileuploadlist.html
>
>Files:
>M      lps/components/incubator/library.lzx
>A      lps/components/incubator/uploader
>A      lps/components/incubator/uploader/fileupload.lzx
>A      lps/components/incubator/uploader/example
>A      lps/components/incubator/uploader/example/test-fileuploadlist.lzx
>A      lps/components/incubator/uploader/example/test-
>multiplefileupload.lzx
>A      lps/components/incubator/uploader/example/test-fileupload.lzx
>A      lps/components/incubator/uploader/example/upload.jsp.txt
>A      lps/components/incubator/uploader/fileuploadlist.lzx
>A      lps/components/incubator/uploader/multiplefileupload.lzx
>
>Changeset: http://svn.openlaszlo.org/openlaszlo/patches/20070604-ben-
>a.tar
>
>
>Benjamin Shine
>Software Engineer, Open Laszlo / Laszlo Systems ben at laszlosystems.com
>
>