[Laszlo-dev] For Review: Change 20070602-ben-v Summary: Don't try to tint a window if there's no style

[J Crowley]

Looks good!  Approved.

On Jun 2, 2007, at 8:28 PM, Benjamin Shine wrote:

> Change 20070602-ben-v by ben at cooper.local on 2007-06-02 17:22:22 PDT
>     in /Users/ben/src/svn/openlaszlo/branches/legals
>     for http://svn.openlaszlo.org/openlaszlo/branches/legals
>
> Summary: Don't try to tint a window if there's no style
>
> New Features: none
>
> Bugs Fixed: LPP-4073 DHTML View Inside a Tabpane cannot contain a  
> Resizable Window
>
> Technical Reviewer: jcrowley (pending)
> QA Reviewer: (pending)
> Doc Reviewer: (pending)
>
> Documentation:
> One of the init handlers for window tries to set the tint of the  
> resize control
> based on the style of the window. In dhtml, we don't use styles,  
> so, this change
> just adds a check-for-null on the style attribute before trying to  
> access
> the style's basecolor.
>
> Release Notes:
>
> Details:
>
> Tests:
> This didn't work before the change, with lzr=dhtml, and now it does:
>     <canvas>
>        <tabs>
>           <tabpane>
>              <view>
>                 <window resizable="true" />
>              </view>
>           </tabpane>
>        </tabs>
>     </canvas>
>
>
> Files:
> M      lps/components/lz/window.lzx
>
> Changeset: http://svn.openlaszlo.org/openlaszlo/patches/20070602- 
> ben-v.tar
>
>
> Benjamin Shine
> Software Engineer, Open Laszlo / Laszlo Systems
> ben at laszlosystems.com
>
>
>