[Laszlo-dev] For Review: Change 20070116-maxcarlson-R Summary: DHTML inputtext floats only when focused,

[Philip Romanik]

approved if you make one change. When testing on IE6, I got an error in 
LaszloView.lzs because this.sprite was null in destroy(). I modified my 
version to test the rest of the change:

function destroy( recursiveCall ){
     if ( this.__LZdeleted ) return;

     if (this.sprite)      <--- My addition
         this.sprite.predestroy();
...


Phil



>Change 20070116-maxcarlson-R by maxcarlson at max-carlsons-
>computer.local on 2007-01-16 16:00:54 PST
>      in /Users/maxcarlson/openlaszlo/legals
>
>Summary: DHTML inputtext floats only when focused,
>
>New Features:
>
>Bugs Fixed: LPP-2977 - Only float inputtext on top of everything else
>when it's focused, LPP-3353 - LzView.destroy should not call moveToFront
>
>Technical Reviewer: promanik
>QA Reviewer: ptw
>Doc Reviewer: (pending)
>
>Documentation:
>
>Release Notes:
>
>Details: lztest-textheight.lzx - added extra tests for inputtext to
>show issues with scrollbars in multiline text for DHTML LzSprite.as - 
>implemented predestroy() for LPP-3353 LzSprite.js - implemented empty 
>predestroy() for LPP-3353, destroy
>__LZinputclickdiv
>LzInputTextSprite.js - Only float inputtext on top of everything else
>when it's focused
>LzTextSprite.js - getTextWidth() on multiline text ingnores the
>width  - per lztest-text.lzx
>LaszloView.lzs - call sprite.predestroy() to give sprites a whack
>before destroying.
>
>
>Tests: http://localhost:8080/legals/examples/components/
>style_example.lzx?lzr=dhtml in firefox 2 os x, IE 7 windows inputtext
>no longer floats above dragged window, but can still type in fields.
>http://localhost:8080/legals/test/lztest/lztest-textheight.lzx?
>lzr=dhtml&debug=true shows additional failure in dhtml for multiline
>inputtext - everything else is normal.  http://localhost:8080/legals/
>test/lztest/lztest-text.lzx?debug=true&lzr=dhtml still failing, but
>no longer fails to get correct size with getTextWidth() in multiline
>text.
>
>
>Files:
>M      test/lztest/lztest-textheight.lzx
>M      WEB-INF/lps/lfc/kernel/swf/LzSprite.as
>M      WEB-INF/lps/lfc/kernel/dhtml/LzSprite.js
>M      WEB-INF/lps/lfc/kernel/dhtml/LzInputTextSprite.js
>M      WEB-INF/lps/lfc/kernel/dhtml/LzTextSprite.js
>M      WEB-INF/lps/lfc/views/LaszloView.lzs
>
>Changeset: http://svn.openlaszlo.org/openlaszlo/patches/20070116-
>maxcarlson-R.tar