[Laszlo-dev] For Review: Change 20070112-maxcarlson-r Summary: Text now defaults to resize=true, updated/fixed unit test, fixed sprites to match trunk

[Philip Romanik]

(I'm only send out one review since the first change package appears to be 
superceded by the second change).

approved.

I got additional errors in Windows depending upon the version of swf and 
browser. lztest-text generates a lot of errors in dhtml, but I think you 
already know that.


lztest-textheight results are below. Interestingly, swf7 differ from swf8. 
dhtml results depend upon the browser used:


lztest-textheight
------------------------

swf8:

ERROR: In suite Text Size Test Suite, test 1, failed assertion: FAIL: 
multiline6 text heightEquals expected 43, got 56
ERROR: In suite Text Size Test Suite, test 1, failed assertion: FAIL: 
multiline6 text.heightEquals expected 43, got 56
ERROR: In suite Text Size Test Suite, test 1, failed assertion: FAIL: 
inputtext5 heightEquals expected 52, got 54
ERROR: In suite Text Size Test Suite, test 1, failed assertion: FAIL: 
inputtext4.heightEquals expected 52, got 54
ERROR: Failed 1 suites, Text Size Test Suite


swf7:

ERROR: In suite Text Size Test Suite, test 1, failed assertion: FAIL: 
inputtext5 heightEquals expected 52, got 54
ERROR: In suite Text Size Test Suite, test 1, failed assertion: FAIL: 
inputtext4.heightEquals expected 52, got 54
ERROR: Failed 1 suites, Text Size Test Suite


FF 1.5 dhtml:

ERROR: In suite Text Size Test Suite, test 1, failed assertion: FAIL: 
inputtext5 heightEquals expected 52, got 54
ERROR: In suite Text Size Test Suite, test 1, failed assertion: FAIL: 
inputtext4.heightEquals expected 52, got 54
ERROR: In suite Text Size Test Suite, test 2, failed assertion: FAIL: 
multiline6 text.widthEquals expected 57, got 100
ERROR: In suite Text Size Test Suite, test 2, failed assertion: FAIL: 
multiline6 text widthEquals expected 57, got 100
ERROR: In suite Text Size Test Suite, test 2, failed assertion: FAIL: text9 
widthEquals expected 88, got 100
ERROR: In suite Text Size Test Suite, test 2, failed assertion: FAIL: text9 
widthEquals expected 88, got 100
ERROR: In suite Text Size Test Suite, test 2, failed assertion: FAIL: 
inputtext5 widthEquals expected 17, got 100
ERROR: In suite Text Size Test Suite, test 2, failed assertion: FAIL: 
inputtext5.widthEquals expected 17, got 100

FF 2 dhtml:

ERROR: In suite Text Size Test Suite, test 1, failed assertion: FAIL: 
multiline6 text heightEquals expected 43, got 56
ERROR: In suite Text Size Test Suite, test 1, failed assertion: FAIL: 
multiline6 text.heightEquals expected 43, got 56
ERROR: In suite Text Size Test Suite, test 1, failed assertion: FAIL: 
inputtext5 heightEquals expected 52, got 54
ERROR: In suite Text Size Test Suite, test 1, failed assertion: FAIL: 
inputtext4.heightEquals expected 52, got 54


IE6/7 dhtml:

ERROR: In suite Text Size Test Suite, test 1, failed assertion: FAIL: 
inputtext5 heightEquals expected 52, got 54
ERROR: In suite Text Size Test Suite, test 1, failed assertion: FAIL: 
inputtext4.heightEquals expected 52, got 54
ERROR: Failed 1 suites, Text Size Test Suite



>Change 20070112-maxcarlson-r by maxcarlson at max-carlsons-
>computer.local on 2007-01-12 21:22:34 PST
>      in /Users/maxcarlson/openlaszlo/legals
>
>Summary: Text now defaults to resize=true, updated/fixed unit test,
>fixed sprites to match trunk
>
>New Features:
>
>Bugs Fixed:
>
>Technical Reviewer: promanik
>QA Reviewer: hminsky
>Doc Reviewer: (pending)
>
>Documentation:
>
>Release Notes:
>
>Details: lztest-textheight.lzx - updated testcase to test resize ==
>true, reflect trunk, more thorough testing.
>
>LzTextSprite.as - move args.width bashing back to LzText.lzs
>
>LzTextSprite.js - move args.width bashing back to LzText.lzs.  Fix
>specific text measurement bug
>
>LzText.lzs - args.width processing from sprites, default resize to
>true, fix multiline arg processing
>
>LzInputTextSprite.as - Turn off resizing.
>
>LzInputTextSprite.js - Clip text correctly.
>
>index.jsp - fix bad link
>
>
>Tests: http://localhost:8080/legals/test/lztest/lztest-textheight.lzx?
>debug=true&lzr=dhtml and http://localhost:8080/legals/test/lztest/
>lztest-textheight.lzx?debug=true&lzr=swf7 lzpix, the components
>sampler.  text9 and text10 text width tests still failing in dhtml.
>http://localhost:8080/legals/test/lztest/lztest-text.lzx mostly
>passing in swf7.
>
>Files:
>M      test/lztest/lztest-text.lzx
>M      test/lztest/lztest-textheight.lzx
>M      WEB-INF/lps/lfc/kernel/swf/LzTextSprite.as
>M      WEB-INF/lps/lfc/kernel/swf/LzInputTextSprite.as
>M      WEB-INF/lps/lfc/kernel/dhtml/LzInputTextSprite.js
>M      WEB-INF/lps/lfc/kernel/dhtml/LzTextSprite.js
>M      WEB-INF/lps/lfc/views/LzText.lzs
>M      index.jsp
>
>Changeset: http://svn.openlaszlo.org/openlaszlo/patches/20070112-
>maxcarlson-r.tar