[Laszlo-dev] For Review: Change submitted Summary: Fix tomcat ant targets on windows

[Benjamin Shine]

Change 20070105-ben-l by ben at bens-g5.local on 2007-01-05 13:37:07 PST
     in /Users/ben/src/svn/openlaszlo/trunk

Summary: Fix tomcat ant targets on windows

New Features:

Bugs Fixed: LPP-2772 uninstall ant target broken
      LPP-3396 ant can't start and stop tomcat on windows

Technical Reviewer: hminsky
QA Reviewer: mamye
Doc Reviewer: (pending)

Documentation:
Call tomcat bash startup & shutdown scripts from inside a new bash  
process, rather than directly exec'ing the bash sript from ant.
Fix brain-o: the uninstall target should call "webapp.uninstall" not  
"webapp.install"

Dan Stowell, who submitted this patch, says it works; it must be  
tested on a few windows machines.

Release Notes:

Details:
Change submitted by Dan Stowell, dstowell at laszlosystems.com. He  
writes: "the one concern I have is that I had to remove a call to  
service.sh to make this work. I assume service.sh creates the  
registry entries necessary to run the LPS Windows service. If so, it  
needs to be run once, after you've built the LPS. I'm hoping someone  
on this list can clarify the matter."

Tests:
On windows:
ant tomcat.start   // server should start
ant tomcat.stop    // server should stop
ant install        // should install lps webapp
ant uninstall      // should uninstall lps webapp

Files:
M      build.xml

Changeset: http://svn.openlaszlo.org/openlaszlo/patches/20070105-ben- 
l.tar