[Laszlo-dev] For Review: Change 20070222-maxcarlson-2 Summary: Fix Safari text measurement, eliminate last use of getters in LFC

Max Carlson max at openlaszlo.org
Thu Feb 22 13:39:55 PST 2007


Change 20070222-maxcarlson-2 by maxcarlson at max-carlsons- 
computer.local on 2007-02-22 13:19:25 PST
     in /Users/maxcarlson/openlaszlo/legals

Summary: Fix Safari text measurement, eliminate last use of getters  
in LFC

New Features:

Bugs Fixed: LPP-3318 - Components - Form Components - Combobox:  
Everything is overlapped and clustered in Safari DHTML, LPP-3317 -  
Components - Sampler: Tabslider does not work in Safari DHTML,  
LPP-3584 - Get rid of getters and getAttribute()

Technical Reviewer: jcrowley
QA Reviewer: papley
Doc Reviewer: (pending)

Documentation:

Release Notes:

Details: LzSprite.js - Add safari_textarea_subtract_scrollbar_height  
quirk

LzInputTextSprite.js - Check for null scrollHeight, add 24 to sccount  
for scrollbar height in Safari

LzTextSprite.js - Check for null scrollHeight

LaszloView.lzs - Remove height/width getters.


Tests: http://localhost:8080/legals/examples/components/ 
combobox_example.lzx?lzr=dhtml, http://localhost:8080/legals/examples/ 
components/tabslider_example.lzx?lzr=dhtml, http://localhost:8080/ 
legals/test/lztest/lztest-textheight.lzx?debug=true&lzr=dhtml run  
consistently in Safari and Firefox 2 on the mac.

Files:
M      WEB-INF/lps/lfc/kernel/dhtml/LzSprite.js
M      WEB-INF/lps/lfc/kernel/dhtml/LzInputTextSprite.js
M      WEB-INF/lps/lfc/kernel/dhtml/LzTextSprite.js
M      WEB-INF/lps/lfc/views/LaszloView.lzs

Changeset: http://svn.openlaszlo.org/openlaszlo/patches/20070222- 
maxcarlson-2.tar


More information about the Laszlo-dev mailing list