[Laszlo-dev] [Laszlo-checkins] r3831 - in openlaszlo/branches/legals: WEB-INF/lps/lfc/services lps/components/utils/diagnostic/inspector lps/components/utils/traits

P T Withington ptw at openlaszlo.org
Mon Feb 19 09:36:03 PST 2007


Ok, that would be great.

On 2007-02-18, at 11:40 EST, Max Carlson wrote:

> It was necessary to get some of the style tests running, because  
> the old tests were looking by classname, e.g. LzView.  I'll see if  
> I can clean up the testcases and back this out.
>
> -Max
>
> On Feb 17, 2007, at 11:01 AM, P T Withington wrote:
>
>> Was this change actually necessary?  There should not be any case  
>> where a class is defined in the global namespace that is not  
>> defined in the lz namespace.  If there is, that is a bug.  The lz  
>> namespace should be authoritative, the global binding is only for  
>> backward compatibility (if it does not conflict with a runtime  
>> binding).
>>
>> On 2007-02-16, at 13:12 EST, max at openlaszlo.org wrote:
>>
>>>          case (this._selTypes.tag ):
>>> -            return node instanceof lz[ rp.classname ];
>>> +            return node instanceof lz[ rp.classname ] || node  
>>> instanceof global[ rp.classname ];
>>>
>>>          case (this._selTypes.compound ):
>>>              var curnode = node;
>>> @@ -275,7 +274,7 @@
>>>
>>>          case (this._selTypes.tagAndAttr ):
>>>              if (node[ rp.attrname ] == rp.attrvalue) {
>>> -                return node instanceof lz[ rp.classname ];
>>> +                return node instanceof lz[ rp.classname ] ||  
>>> node instanceof global[ rp.classname ];
>>>              }
>>>              return false;
>>>      }
>>
>



More information about the Laszlo-dev mailing list