[Laszlo-dev] [Laszlo-checkins] r3815 - in openlaszlo/branches/legals/test/style: . fake names

[Benjamin Shine]

I rearranged designerview to not use the cssable mixin. Checked in as  
r3816.
Now I should fix all the places in the tests that use cssable, make  
them use style constraints.

On Feb 14, 2007, at 12:42 PM, Benjamin Shine wrote:

> Correct. The designerview still relies on it, but it would be very  
> easy to rewrite with $style constraints. I volunteer.
>
> On Feb 14, 2007, at 12:34 PM, Max Carlson wrote:
>
>> I think it did - but a lot of the style tests still rely on it.
>>
>> P T Withington wrote:
>>> I just have one question:  I thought that the cssable mixin  
>>> became obsolete when we move applyStyles to LzNode.construct   
>>> (circa line 180):
>>>>         var styleMap = this.$styles();
>>>>         if ( styleMap ) {
>>>>             this.__LZstyleConstraints = this.__LZapplyStyleMap 
>>>> ( styleMap, attrs );
>>>>         }
>>> Ben?
>>> On 2007-02-14, at 14:38 EST, max at openlaszlo.org wrote:
>>>> Author: max
>>>> Date: 2007-02-14 11:38:15 -0800 (Wed, 14 Feb 2007)
>>>> New Revision: 3815
>>>>
>>>> Modified:
>>>>    openlaszlo/branches/legals/test/style/designerview.lzx
>>>>    openlaszlo/branches/legals/test/style/fake/html-fake- 
>>>> elements.lzx
>>>>    openlaszlo/branches/legals/test/style/names/main_dash.lzx
>>>> Log:
>>>> + update style examples.  Now they all pass under legals (or  
>>>> fail consistently with trunk)
>>>>
>>>> Modified: openlaszlo/branches/legals/test/style/designerview.lzx
>>>> ===================================================================
>>>> --- openlaszlo/branches/legals/test/style/designerview.lzx     
>>>> 2007-02-14 08:00:01 UTC (rev 3814)
>>>> +++ openlaszlo/branches/legals/test/style/designerview.lzx     
>>>> 2007-02-14 19:38:15 UTC (rev 3815)
>>>> @@ -1,9 +1,9 @@
>>>> -<!-- Copyright 2006 Laszlo Systems -->
>>>> +<!-- Copyright 2007 Laszlo Systems -->
>>>>  <library>
>>>>
>>>>  <include href="utils/traits/cssable.lzx" />
>>>>
>>>> -<class name="designerview" traits="cssable"
>>>> +<class name="designerview" with="cssable"
>>>>      width="50" height="50" >
>>>>
>>>>      <!-- List the attributes which will be styled by CSS -->
>>>> @@ -42,4 +42,4 @@
>>>>          </view>
>>>>      </view>
>>>>  </class>
>>>> -</library>
>>>> \ No newline at end of file
>>>> +</library>
>>>>
>>>> Modified: openlaszlo/branches/legals/test/style/fake/html-fake- 
>>>> elements.lzx
>>>> ===================================================================
>>>> --- openlaszlo/branches/legals/test/style/fake/html-fake- 
>>>> elements.lzx    2007-02-14 08:00:01 UTC (rev 3814)
>>>> +++ openlaszlo/branches/legals/test/style/fake/html-fake- 
>>>> elements.lzx    2007-02-14 19:38:15 UTC (rev 3815)
>>>> @@ -1,10 +1,10 @@
>>>> -<!-- Copyright 2006 Laszlo Systems -->
>>>> +<!-- Copyright 2007 Laszlo Systems -->
>>>>  <library>
>>>>
>>>>  <include href="utils/traits/cssable.lzx" />
>>>>
>>>>
>>>> -<class name="basefaker" traits="cssable" opacity="0.5">
>>>> +<class name="basefaker" with="cssable" opacity="0.5">
>>>>      <simplelayout axis="y" spacing="2" />
>>>>      <text text="${this.classroot.class.name}" />
>>>>
>>>> @@ -17,7 +17,7 @@
>>>>  <class name="fakebody" extends="basefaker" bgcolor="#dadada"
>>>>       x="10" width="${parent.width-20}" />
>>>>
>>>> -<class name="fakep" extends="text" bgcolor="#cacaca"   
>>>> traits="cssable"
>>>> +<class name="fakep" extends="text" bgcolor="#cacaca"   
>>>> with="cssable"
>>>>      x="10" width="${parent.width-20}" opacity="0.5">
>>>>      <simplelayout axis="y" spacing="2" />
>>>>      <text text="${this.classroot.class.name}" />
>>>> @@ -35,4 +35,4 @@
>>>>
>>>>  <class name="fakespan" extends="fakep" bgcolor="#555555"/>
>>>>
>>>> -</library>
>>>> \ No newline at end of file
>>>> +</library>
>>>>
>>>> Modified: openlaszlo/branches/legals/test/style/names/main_dash.lzx
>>>> ===================================================================
>>>> --- openlaszlo/branches/legals/test/style/names/main_dash.lzx     
>>>> 2007-02-14 08:00:01 UTC (rev 3814)
>>>> +++ openlaszlo/branches/legals/test/style/names/main_dash.lzx     
>>>> 2007-02-14 19:38:15 UTC (rev 3815)
>>>> @@ -16,7 +16,7 @@
>>>>
>>>>      <include href="utils/traits/cssable.lzx" />
>>>>
>>>> -    <class name="B" traits="cssable" bgcolor="0x776699"  
>>>> width="50" height="50">
>>>> +    <class name="B" with="cssable" bgcolor="0x776699"  
>>>> width="50" height="50">
>>>>          <handler name="onconstruct" method="_applyCSS" />
>>>>          <attribute name="cssPropertyMap"
>>>>              value="{width: 'width', bgcolor: 'lzx-bgcolor',  
>>>> coolness: 'coolness', height: 'lzxheight'}" />
>>>>
>>>>
>>>> _______________________________________________
>>>> Laszlo-checkins mailing list
>>>> Laszlo-checkins at openlaszlo.org
>>>> http://www.openlaszlo.org/mailman/listinfo/laszlo-checkins
>>
>> -- 
>> Regards,
>> Max Carlson
>> OpenLaszlo.org
>
> Benjamin Shine
> Software Engineer, Open Laszlo / Laszlo Systems
> ben at laszlosystems.com
>
>
>

Benjamin Shine
Software Engineer, Open Laszlo / Laszlo Systems
ben at laszlosystems.com