[Laszlo-dev] For Review: Change 20070213-maxcarlson-P Summary: Shared browser detection, Safari detection based off webkit build id, Lz.setCanvasAttribute() calls are queued until the flash communication system is ready

Max Carlson max at openlaszlo.org
Tue Feb 13 13:38:53 PST 2007


Change 20070213-maxcarlson-P by maxcarlson at max-carlsons- 
computer.local on 2007-02-13 13:23:01 PST
     in /Users/maxcarlson/openlaszlo/legals

Summary: Shared browser detection, Safari detection based off webkit  
build id, Lz.setCanvasAttribute() calls are queued until the flash  
communication system is ready

New Features:

Bugs Fixed: LPP-3193 - Lz.setCanvasAttribute() calls should be queued  
until the flash communication system is ready, LPP-3312 - Key Safari  
browser detection off webkit build id, LPP-3311 - Unify browser  
sniffing code

Technical Reviewer: jcrowley
QA Reviewer: promanik
Doc Reviewer: (pending)

Documentation:

Release Notes:

Details: test6.html - add lzOptions.ServerRoot so history knows where  
to load from

copy-of-hello.lzx - Add listener for canvas.historyinit attribute -  
currently set by the history system when it starts

test8.html - add lzOptions.ServerRoot so history knows where to load  
from

LzSprite.js - Move __BrowserDetect out of quirks.  Make sure  
window.Lz exists before running browser tests for quirks so lzunit  
passes.

embednew.js - Add basic embed for history checking code.  Moved  
__BrowserDetect from LzSprite.js to here so it can be shared.  Update  
__isSupportedBrowser() to use __BrowserDetect.  Update  
__BrowserDetect.dataBrowser.versionSearch entry to grab Webkit build  
ID for Safari family.  Implement queueing for setCanvasAttribute().   
Warn for calls made to getCanvasAttribute() before flash comm is  
ready.  Add _lzHistEmbed() to write history iframe into page.

h2.html - Add initial version of history loader html, currently  
calling Lz.setCanvasAttribute('historyinit', 'true') to test queueing.

Tests: test/lfc/legals/testjscomm/test6.html and test/lfc/legals/ 
testjscomm/test8.html shows green 'true' to verify canvas attribute  
queueing is working, no regressions under Safari or Webkit

Files:
M      test/lfc/legals/testjscomm/test6.html
M      test/lfc/legals/testjscomm/copy-of-hello.lzx
M      test/lfc/legals/testjscomm/test8.html
M      WEB-INF/lps/lfc/kernel/dhtml/LzSprite.js
M      lps/includes/source/embednew.js
A      lps/includes/h2.html

Changeset: http://svn.openlaszlo.org/openlaszlo/patches/20070213- 
maxcarlson-P.tar


More information about the Laszlo-dev mailing list