[Laszlo-dev] For Review: Change 20070209-Philip-0 Summary: Prevent referencing undefined variables.

[P T Withington]

I guess you could have been a teeny bit more efficient by combining  
the `if (this.parent/immediateparent` of the debug and non-debug  
paths.  The setting that the debug path is trying to warn about  
clobbering is already protected by a test for the parent/ 
immediateparent existing.  OTOH, the way you did it is the lowest risk.

On 2007-02-09, at 18:57 EST, Philip Romanik wrote:

> Thanks Tucker. It's checked in as revision 3774.
>
>> Approved.
>>
>> On 2007-02-09, at 17:47 EST, Philip Romanik wrote:
>>
>> > Change 20070209-Philip-0 by Philip at Philip-DC on 2007-02-09 17:32:38
>> > EST
>> >     in /cygdrive/f/laszlo/svn/src/svn/openlaszlo/branches/legals
>> >
>> > Summary: Prevent referencing undefined variables.
>> >
>> > New Features:
>> >
>> > Bugs Fixed:
>> >
>> > Technical Reviewer: jcrowley
>> > QA Reviewer: (pending)
>> > Doc Reviewer: (pending)
>> >
>> > Documentation:
>> >
>> > Release Notes:
>> >
>> > Details:
>> > I found 2 places in the code that can reference undefined variables
>> > when $debug is set. This made it difficult in dhtml to track down
>> > the actual cause of the pr oblem.
>> >
>> > Tests:
>> > inspection. The checks I added are run outside the $debug block but
>> > not used ins ide it.
>> >
>> > Files:
>> > M      WEB-INF/lps/lfc/core/LzNode.lzs
>> >
>> > Changeset: http://svn.openlaszlo.org/openlaszlo/patches/20070209-
>> > Philip-0.tar
>> >
>