[Laszlo-dev] For Review: Change 20070829-jcrowley-P Summary: setVisibility was not an approved API change

P T Withington ptw at openlaszlo.org
Wed Aug 29 05:39:22 PDT 2007


Approved!

One suggestion:  When specifying the Bugs Fixed, list them 1 per  
line, after the section and use the bug title too.  A belt-and- 
suspenders approach, but I think it makes it easier for branch  
managers to search for changes and bugs.  Thus:

Bugs Fixed:
LPP-4543 setVisibility was not an approved API change

On 2007-08-29, at 00:31 EDT, J Crowley wrote:

> Change 20070829-jcrowley-P by jcrowley at doctormanhattan.mshome.net  
> on 2007-08-29 00:26:11 EDT
>     in /Users/jcrowley/src/svn/openlaszlo/waffle
>     for http://svn.openlaszlo.org/openlaszlo/branches/wafflecone
>
> Summary: setVisibility was not an approved API change
>
> New Features:
>
> Bugs Fixed: LPP-4543
>
> Technical Reviewer: ptw
> QA Reviewer: (pending)
> Doc Reviewer: (pending)
>
> Documentation:
>
> Release Notes:
>
> Details: Commented out warning, changed visibility stuff in
> 	view to @access private.  Fixed ordering of setVisibility
> 	to match setVisible.
>
> Tests: Build docs, note absence of setVisibility and related
> 	elements from the refguide for View.  Run the Calendar
> 	demo with debug=true, click the "i" to open up the info
> 	panel, note an absence of warnings about "setVisibility"
> 	in the Debugger.
>
> Files:
> M      WEB-INF/lps/lfc/views/LaszloView.lzs
>
> Changeset: http://svn.openlaszlo.org/openlaszlo/patches/20070829- 
> jcrowley-P.tar



More information about the Laszlo-dev mailing list