[Laszlo-dev] For Review: Change 20070815-maxcarlson-U Summary: Add flag only setAttribute() if it changed

[P T Withington]

Not approved:

Unless I am really confused, I don't think your test is correct.

And, I am not convinced this is a good change, since it is highly  
likely our event system depends on an event being sent _any_ time an  
attribute is set, whether it is changed or not.

On 2007-08-15, at 14:23 EDT, Max Carlson wrote:

> Change 20070815-maxcarlson-U by maxcarlson at plastik on 2007-08-15  
> 11:16:52 PDT
>     in /Users/maxcarlson/openlaszlo/wafflecone
>     for http://svn.openlaszlo.org/openlaszlo/branches/wafflecone
>
> Summary: Add flag only setAttribute() if it changed
>
> New Features:
>
> Bugs Fixed:
>
> Technical Reviewer: ptw
> QA Reviewer: promanik
> Doc Reviewer: (pending)
>
> Documentation:
>
> Release Notes:
>
> Details: Add a flag that only sets the attribute if its value  
> changed.  It's a common pattern to only set an attribute when it  
> changed.  With inlining of setAttribute it will also make sense for  
> performance.
>
>
> Tests: IWFM
>
> Files:
> M      WEB-INF/lps/lfc/core/LzNode.lzs
>
> Changeset: http://svn.openlaszlo.org/openlaszlo/patches/20070815- 
> maxcarlson-U.tar