[Laszlo-dev] For Review: Change 20070806-maxcarlson-l Summary: Only set style constraints if the existing value is null

[P T Withington]

Question: Can you explain how this change works?  And if so, could we  
have a comment in the code so that future generations will  
understand?  Is the test for the attribute in initialArgs no longer  
necessary?  Is your modification only applicable to style  
constraints, or should it also apply to the other branch of the if, a  
constant style?

Approved because it works, but it sure would be nice to understand why.

On 2007-08-06, at 21:57 EDT, Max Carlson wrote:

> Change 20070806-maxcarlson-l by maxcarlson at plastik on 2007-08-06  
> 18:53:14 PDT
>     in /Users/maxcarlson/openlaszlo/wafflecone
>     for http://svn.openlaszlo.org/openlaszlo/branches/wafflecone
>
> Summary: Only set style constraints if the existing value is null
>
> New Features:
>
> Bugs Fixed: LPP-2894 - CSS: subclasses and instances can't override  
> style constraints set on superclass*
>
> Technical Reviewer: promanik
> QA Reviewer: ben, ptw
> Doc Reviewer: (pending)
>
> Documentation:
>
> Release Notes:
>
> Details: LzNode.lzs - Only set styleConstraints[k] if this[k] is null.
>
>
> Tests: http://localhost:8080/wafflecone/test/style/constraints/ 
> main.lzx?lzr=swf8 now passes.
>
> Files:
> M      WEB-INF/lps/lfc/core/LzNode.lzs
>
> Changeset: http://svn.openlaszlo.org/openlaszlo/patches/20070806- 
> maxcarlson-l.tar