[Laszlo-dev] For Review: Change 20070801-maxcarlson-k Summary: Inline LzCSSStyle._selectorApplies() testing and first level of recursion
promanik at laszlosystems.com
Wed Aug 1 13:55:57 PDT 2007
Approved (as far as code changes and that it appears to function correctly).
I saw similar method-call improvements when using Firebug. However, I don't
show much improvement in the start-up time. For dhtml I used Firebug to
show the total time to execute (until the error occurs). For swf7 I used a
stopwatch to measure the startup time using a freshly loaded FF 1.5.
Before After (using this patch)
swf7 12.1 sec 11.8 sec
dhtml 7.9 sec 7.8 sec
>Change 20070801-maxcarlson-k by maxcarlson at plastik on 2007-08-01
> in /Users/maxcarlson/openlaszlo/wafflecone
> for http://svn.openlaszlo.org/openlaszlo/branches/wafflecone
>Summary: Inline LzCSSStyle._selectorApplies() testing and first level
>Bugs Fixed: LPP-4414 - Improve startup performance (partial)
>Technical Reviewer: promanik
>QA Reviewer: ben
>Doc Reviewer: (pending)
>Details: Do early tests to short-circuit calls to _selectorApplies
>(). Change structure of _selectorApplies() to set a result variable
>and break rather than retunring immediately. Inline first level of
>recursion (ugly, but it gets the most results).
>Tests: Silver main.lzx?lzr=dhtml&lzt=html shows a total of 56350
>fewer function calls in firebug (from 307750 to 251400). Calls to
>_selectorApplies() have been reduced from 125068 to 66294 calls.
More information about the Laszlo-dev