[Laszlo-dev] For Review: Change 20070731-Philip-4. Summary: Wafflecone: Only write 'validate' attribute if explicitly defined by the user

[P T Withington]

Approved!

On 2007-07-31, at 17:27 EDT, Philip Romanik wrote:

> Change 20070731-Philip-4 by Philip at Philip-DC on 2007-07-31 17:09:38  
> EST
>     in /cygdrive/f/laszlo/svn/src/svn/openlaszlo/branches/wafflecone
>     for http://svn.openlaszlo.org/openlaszlo/branches/wafflecone
>
> Summary: Wafflecone: Only write 'validate' attribute if explicitly  
> defined by the user
>
> New Features:
>
> Bugs Fixed: LPP-3988
>
> Technical Reviewer: ptw
> QA Reviewer: (pending)
> Doc Reviewer: (pending)
>
> Documentation:
>
> Release Notes:
>
> Details:
> A canvas or library can define an attribute called 'validate' to  
> bypass XML validation. If the user does not explicitly define it,  
> validate is set to true. With  binary libraries, validate was  
> unconditionally written to the output. This causes warning messages  
> like the ones mentioned in LPP-3988. The fix is to write the  
> validate attribute only when explicitly defined inside a library.
>
> CompilationEnvironment.java
>   Define a new property, e_validate, that is defined only when the  
> user explicitly defines the validate attribute.
>
> ToplevelCompiler.java
>   Modified setValidateProperty() to set e_validate if the user  
> specified the validate attribute in the canvas or library.
>
> LibraryWriter.java
>   Writes validate attribute only if e_validate and validate are  
> defined properties.
>
>
> Tests:
>   See test file attached to LPP-3988.lzx. When run without this  
> patch, a warning is generated when lpp3988.lzx is run. No warning  
> is reported when the patch is applied. You can also look inside the  
> two binary compiled files to see that 'validate' is only written  
> when explicitly specified.
>
> Files:
> M      WEB-INF/lps/server/src/org/openlaszlo/compiler/ 
> ToplevelCompiler.java
> M      WEB-INF/lps/server/src/org/openlaszlo/compiler/ 
> LibraryWriter.java
> M WEB-INF/lps/server/src/org/openlaszlo/compiler/ 
> CompilationEnvironment.java
>
> Changeset: http://svn.openlaszlo.org/openlaszlo/patches/20070731- 
> Philip-4.tar
>
>